-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: Do not throw an error when switching between queued dapp transactions #39128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (5 files, +244 -26)
|
...ages/confirmations/components/transactions/nested-transaction-tag/nested-transaction-tag.tsx
Outdated
Show resolved
Hide resolved
Builds ready [149dcdb]
UI Startup Metrics (1346 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
149dcdb to
2bda610
Compare
...firmations/components/confirm/info/shared/quote-transaction-data/quoted-transaction-data.tsx
Outdated
Show resolved
Hide resolved
Builds ready [b2cd099]
UI Startup Metrics (1274 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [bfc3bc5]
UI Startup Metrics (1307 ± 124 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...firmations/components/confirm/info/shared/quote-transaction-data/quoted-transaction-data.tsx
Show resolved
Hide resolved
Builds ready [a2df3fd]
UI Startup Metrics (1301 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [a2df3fd]
UI Startup Metrics (1301 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
a2df3fd to
c2d9bdc
Compare
Builds ready [c2d9bdc]
UI Startup Metrics (1326 ± 121 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Do not throw an error when switching between queued dapp transactions.
Changelog
CHANGELOG entry: Do not throw an error when switching between queued dapp transactions
Related issues
Fixes: #29191
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Prevents React hook-order errors when switching between confirmations from different dapps.
QuotedSwapTransactionDatainto guarded wrapper +...Content; render only whenisQuotedSwapDisplayedInInfoandselectedQuoteare set, key byselectedQuote.quote.requestId, and pass empty arrays touseNestedTransactionLabelswhenapproval/tradeare absentAdvancedDetailsto always includeQuotedSwapTransactionData(internal guard handles visibility)NestedTransactionTaginto wrapper +...Content; render only for valid batch with> 1items and key bycurrentConfirmation.idWritten by Cursor Bugbot for commit c2d9bdc. This will update automatically on new commits. Configure here.