Skip to content

Conversation

@dan437
Copy link
Contributor

@dan437 dan437 commented Jan 9, 2026

Description

Do not throw an error when switching between queued dapp transactions.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Do not throw an error when switching between queued dapp transactions

Related issues

Fixes: #29191

Manual testing steps

  1. Connect to dapp 1 (https://www.sushi.com/fantom/swap)
  2. Connect to dapp 2 (https://app.uniswap.org/swap)
  3. Add a new network from dapp1 and do not submit the transaction
  4. Enter details for a swap on dapp 2, submit it
  5. Switch between confirmations, it will no longer throw an error

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Prevents React hook-order errors when switching between confirmations from different dapps.

  • Split QuotedSwapTransactionData into guarded wrapper + ...Content; render only when isQuotedSwapDisplayedInInfo and selectedQuote are set, key by selectedQuote.quote.requestId, and pass empty arrays to useNestedTransactionLabels when approval/trade are absent
  • Update AdvancedDetails to always include QuotedSwapTransactionData (internal guard handles visibility)
  • Refactor NestedTransactionTag into wrapper + ...Content; render only for valid batch with > 1 items and key by currentConfirmation.id
  • Add tests covering transitions: defined→undefined quote, approval presence changes, batch→non-batch, and varying nested counts without throwing

Written by Cursor Bugbot for commit c2d9bdc. This will update automatically on new commits. Configure here.

@dan437 dan437 requested a review from a team as a code owner January 9, 2026 14:42
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 9, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 9, 2026

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (5 files, +244 -26)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 confirm/
            • 📁 info/
              • 📁 shared/
                • 📁 advanced-details/
                  • 📄 advanced-details.tsx +1 -3
                • 📁 quote-transaction-data/
                  • 📄 quoted-transaction-data.test.tsx +92 -0
                  • 📄 quoted-transaction-data.tsx +38 -11
          • 📁 transactions/
            • 📁 nested-transaction-tag/
              • 📄 nested-transaction-tag.test.tsx +69 -0
              • 📄 nested-transaction-tag.tsx +44 -12

@github-actions github-actions bot added the size-M label Jan 9, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 9, 2026

Builds ready [149dcdb]
UI Startup Metrics (1346 ± 95 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1346112316379514101494
load111893013328911751265
domContentLoaded111192613288911701259
domInteractive2817105192583
firstPaint187661216184205318
backgroundConnect23020826411236252
firstReactRender1794271834
getState3819107134565
initialActions104113
loadScripts8886931109899481035
setupStore1373951325
numNetworkReqs171171151165
BrowserifyPower User HomeuiStartup19011496245419320152362
load1039896137911810601294
domContentLoaded1026889137112010521288
domInteractive34181442432103
firstPaint208701332205235448
backgroundConnect284203749137244631
firstReactRender23165162436
getState17414229326191231
initialActions103112
loadScripts81267911601158311071
setupStore18104571937
numNetworkReqs58371322262121
WebpackStandard HomeuiStartup821660112286876988
load66158583970692813
domContentLoaded65657883269686808
domInteractive2616107192281
firstPaint1146127254164226
backgroundConnect3061373441114
firstReactRender16113141726
getState3214147194361
initialActions106112
loadScripts65257682968683803
setupStore1263861327
numNetworkReqs181181181173
WebpackPower User HomeuiStartup1338971204224115031749
load679582112089691895
domContentLoaded669575110689681887
domInteractive34161693129111
firstPaint1526252784202299
backgroundConnect107762519721558
firstReactRender23173642430
getState15113027721153199
initialActions102111
loadScripts666573109787678879
setupStore1564761631
numNetworkReqs58351482757139
FirefoxBrowserifyStandard HomeuiStartup13831067218321114941847
load1107909184915612001347
domContentLoaded1107909184915612001342
domInteractive66313844885139
firstPaint------
backgroundConnect59173645967179
firstReactRender1293631216
getState126111111123
initialActions103122
loadScripts1072895180514311151235
setupStore134180191044
numNetworkReqs20983191375
BrowserifyPower User HomeuiStartup24971930498956125074047
load12491015273836511972607
domContentLoaded12491015273836511972607
domInteractive131331008152113353
firstPaint------
backgroundConnect128301043186116785
firstReactRender251584132464
getState32867911240534778
initialActions203123
loadScripts1191994263230011401778
setupStore1246696166117649
numNetworkReqs57292094446186
WebpackStandard HomeuiStartup15691276221016916921855
load13321104201013913941559
domContentLoaded13321104200913913941559
domInteractive812724543101159
firstPaint------
backgroundConnect63221874387150
firstReactRender14104641520
getState198251301655
initialActions102122
loadScripts12891086198813213481536
setupStore184232271362
numNetworkReqs19980191475
WebpackPower User HomeuiStartup28652108676679328134610
load16081207350654516942987
domContentLoaded16081207350654516932987
domInteractive127321151172105508
firstPaint------
backgroundConnect1763114912641491005
firstReactRender2516113122840
getState308711019259502844
initialActions217123
loadScripts15181191299944915762827
setupStore9612153617582350
numNetworkReqs58291903874161
📊 Page Load Benchmark Results

Current Commit: 149dcdb | Date: 1/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.08s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 753ms (±38ms) 🟢 | historical mean value: 716ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 82ms (±10ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.08s 40ms 1.05s 1.36s 1.12s 1.36s
domContentLoaded 753ms 38ms 727ms 1.02s 798ms 1.02s
firstPaint 82ms 10ms 64ms 168ms 88ms 168ms
firstContentfulPaint 82ms 10ms 64ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 387 Bytes (0%)
  • common: 20 Bytes (0%)

@dan437 dan437 force-pushed the queued-transactions-fix branch from 149dcdb to 2bda610 Compare January 12, 2026 10:15
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 12, 2026

Builds ready [b2cd099]
UI Startup Metrics (1274 ± 108 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--12741009158710813351436
load--1071853130110011351248
domContentLoaded--1064851129510011271243
domInteractive--251594202187
firstPaint--1396732263184286
backgroundConnect--21419525511218239
firstReactRender--1593551723
getState--361798134263
initialActions--104112
loadScripts--85965010931009211045
setupStore--1272841420
numNetworkReqs--171180171168
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--------
load--------
domContentLoaded--------
domInteractive--------
firstPaint--------
backgroundConnect--------
firstReactRender--------
getState--------
initialActions--------
loadScripts--------
setupStore--------
numNetworkReqs--------
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--799655107876839927
load--63657083564671782
domContentLoaded--63156482663666775
domInteractive--241488182079
firstPaint--1096031158143258
backgroundConnect--3251733447100
firstReactRender--15112831621
getState--3315131204262
initialActions--102111
loadScripts--62756281662663767
setupStore--1174471234
numNetworkReqs--171176171169
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--------
load--------
domContentLoaded--------
domInteractive--------
firstPaint--------
backgroundConnect--------
firstReactRender--------
getState--------
initialActions--------
loadScripts--------
setupStore--------
numNetworkReqs--------
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13971095246523114781860
load--1122906221918711701361
domContentLoaded--1121906221918711701361
domInteractive--7431109910886135
firstPaint--------
backgroundConnect--60203376071189
firstReactRender--13102531221
getState--136156201124
initialActions--102012
loadScripts--1085890219817611351294
setupStore--183220301450
numNetworkReqs--20981191477
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--24941732476561925154143
load--12621056278936911992485
domContentLoaded--12621056278936911992484
domInteractive--1163743780117362
firstPaint--------
backgroundConnect--138381055167133489
firstReactRender--24166192652
getState--23271821185295678
initialActions--217123
loadScripts--12221026259233611742304
setupStore--11111766149112553
numNetworkReqs--56211874449176
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15461326213816316451842
load--13081128157310713841513
domContentLoaded--13071128157210713831513
domInteractive--742815537100133
firstPaint--------
backgroundConnect--67182205090179
firstReactRender--14115451524
getState--227272411662
initialActions--102122
loadScripts--1263110514878613171449
setupStore--183151231471
numNetworkReqs--20986201382
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29061968782694027764824
load--16391072314056418142966
domContentLoaded--16391071313956418132965
domInteractive--139291050175106555
firstPaint--------
backgroundConnect--1742313002471921047
firstReactRender--23155362632
getState--278801049247394819
initialActions--203123
loadScripts--15491056291446517542757
setupStore--1017116517176576
numNetworkReqs--56291943682137
19--------
📊 Page Load Benchmark Results

Current Commit: b2cd099 | Date: 1/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±45ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 715ms (±41ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 45ms 1.00s 1.35s 1.04s 1.35s
domContentLoaded 715ms 41ms 695ms 1.01s 724ms 1.01s
firstPaint 74ms 11ms 56ms 164ms 84ms 164ms
firstContentfulPaint 74ms 11ms 56ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 292 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 12, 2026

Builds ready [bfc3bc5]
UI Startup Metrics (1307 ± 124 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13071049161712413921496
load--1101858140311811731288
domContentLoaded--1095853139711711671279
domInteractive--271599202284
firstPaint--1496335263192268
backgroundConnect--21520025810218232
firstReactRender--1593141723
getState--3520117123856
initialActions--103111
loadScripts--88765411901179581074
setupStore--1273241319
numNetworkReqs--171176171170
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--18741464247820619812357
load--1011886141911110401296
domContentLoaded--1000881139511110261281
domInteractive--33171312630110
firstPaint--177701411144218350
backgroundConnect--261194642112234602
firstReactRender--22164852329
getState--17613927231192243
initialActions--107112
loadScripts--78967111841098121082
setupStore--1795281835
numNetworkReqs--58381382460127
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--793662116385813980
load--63857693768649787
domContentLoaded--63357193167643781
domInteractive--2615115212184
firstPaint--1045935349134196
backgroundConnect--3251233050100
firstReactRender--16112931723
getState--3215100164162
initialActions--105112
loadScripts--63056992266641773
setupStore--1365391436
numNetworkReqs--181178181169
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14061038218927615102081
load--714606106590719910
domContentLoaded--704598105690713903
domInteractive--38182363535124
firstPaint--1526954190190339
backgroundConnect--71965014720533
firstReactRender--23173742532
getState--16913572181164238
initialActions--102011
loadScripts--701595104888711894
setupStore--18962111845
numNetworkReqs--59352243056132
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14561144249324015701931
load--1167977227219112321414
domContentLoaded--1167971227119112321413
domInteractive--8131120211994152
firstPaint--------
backgroundConnect--62193025475173
firstReactRender--13102531319
getState--145135181130
initialActions--103122
loadScripts--1127960219817711831314
setupStore--154178251228
numNetworkReqs--19980191474
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25321879492860224824223
load--1308991288545612752626
domContentLoaded--1308991288545612752626
domInteractive--159341218222121478
firstPaint--------
backgroundConnect--128231004170121470
firstReactRender--23156282538
getState--302641172255447810
initialActions--213123
loadScripts--1259971284042412482609
setupStore--1406866185168619
numNetworkReqs--60302034086148
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16331308217218417462013
load--13661138172912714431596
domContentLoaded--13661137172912714421596
domInteractive--852927451130177
firstPaint--------
backgroundConnect--65193035079168
firstReactRender--15115951620
getState--218250321775
initialActions--103122
loadScripts--13271120165210913981538
setupStore--205250361483
numNetworkReqs--19985191475
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29572137829496030514726
load--16321148308253317622891
domContentLoaded--16321147307753317622891
domInteractive--12427996148108482
firstPaint--------
backgroundConnect--1873512112641771029
firstReactRender--2716156192835
getState--28871964234402807
initialActions--208123
loadScripts--15241119287441417002600
setupStore--14973587379116669
numNetworkReqs--59272064350190
19--------
📊 Page Load Benchmark Results

Current Commit: bfc3bc5 | Date: 1/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 717ms (±35ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 37ms 1.01s 1.30s 1.07s 1.30s
domContentLoaded 717ms 35ms 696ms 981ms 751ms 981ms
firstPaint 76ms 10ms 60ms 168ms 84ms 168ms
firstContentfulPaint 76ms 10ms 60ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 314 Bytes (0%)
  • common: 20 Bytes (0%)

@dan437 dan437 enabled auto-merge January 12, 2026 13:30
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 12, 2026

Builds ready [a2df3fd]
UI Startup Metrics (1301 ± 113 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13011051174911313561460
load--108187814409711301222
domContentLoaded--107487014319711221205
domInteractive--2716103202390
firstPaint--151661123121192308
backgroundConnect--22119929616225252
firstReactRender--16104161729
getState--3719110163975
initialActions--107112
loadScripts--8616521204969091001
setupStore--1162631219
numNetworkReqs--171176161166
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--18881537257118620262281
load--1020892137011710451306
domContentLoaded--1008885136011810341300
domInteractive--3417233303399
firstPaint--183661382184212409
backgroundConnect--291201763144240611
firstReactRender--23165672440
getState--18213883370188223
initialActions--103112
loadScripts--79968311541158221086
setupStore--1894681939
numNetworkReqs--59371682461118
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--8046501193918471009
load--64157988464689764
domContentLoaded--63657488064685751
domInteractive--2515110192279
firstPaint--1055932150139214
backgroundConnect--2851223138105
firstReactRender--16103951726
getState--3215134184162
initialActions--104112
loadScripts--63357287762683743
setupStore--1152851224
numNetworkReqs--181178181167
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13501004214625314521884
load--68359994180693898
domContentLoaded--67359293280680892
domInteractive--35181432932121
firstPaint--1346442580150328
backgroundConnect--93863618420579
firstReactRender--23173632529
getState--1507321116158179
initialActions--102111
loadScripts--66959092278677882
setupStore--1894991844
numNetworkReqs--994024046136218
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13831080240021914691775
load--1103923203216511631318
domContentLoaded--1102922203216511581318
domInteractive--71328728786134
firstPaint--------
backgroundConnect--55191944674174
firstReactRender--1394351322
getState--1257781323
initialActions--103122
loadScripts--1068907194414911191227
setupStore--144111141146
numNetworkReqs--19980191376
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25081839506355925153992
load--1247964268634612252194
domContentLoaded--1246964268634612242193
domInteractive--1112348778115315
firstPaint--------
backgroundConnect--105241156121108271
firstReactRender--23156782532
getState--26243984220316803
initialActions--207123
loadScripts--1200948261731211951992
setupStore--1216738155117531
numNetworkReqs--61292745070169
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15791250240722716562033
load--13111102167912613951538
domContentLoaded--13111101167912613951538
domInteractive--792817838118142
firstPaint--------
backgroundConnect--66203305581214
firstReactRender--14112631520
getState--2082293315111
initialActions--103122
loadScripts--12741052164711413551461
setupStore--204207351377
numNetworkReqs--19981191478
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--------
load--------
domContentLoaded--------
domInteractive--------
firstPaint--------
backgroundConnect--------
firstReactRender--------
getState--------
initialActions--------
loadScripts--------
setupStore--------
numNetworkReqs--------
19--------
📊 Page Load Benchmark Results

Current Commit: a2df3fd | Date: 1/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±35ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 707ms (±33ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 35ms 1.01s 1.30s 1.07s 1.30s
domContentLoaded 707ms 33ms 686ms 947ms 727ms 947ms
firstPaint 76ms 12ms 60ms 168ms 88ms 168ms
firstContentfulPaint 76ms 12ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 54 Bytes (0%)
  • common: 652 Bytes (0.01%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 12, 2026

Builds ready [a2df3fd]
UI Startup Metrics (1301 ± 113 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13011051174911313561460
load--108187814409711301222
domContentLoaded--107487014319711221205
domInteractive--2716103202390
firstPaint--151661123121192308
backgroundConnect--22119929616225252
firstReactRender--16104161729
getState--3719110163975
initialActions--107112
loadScripts--8616521204969091001
setupStore--1162631219
numNetworkReqs--171176161166
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--18881537257118620262281
load--1020892137011710451306
domContentLoaded--1008885136011810341300
domInteractive--3417233303399
firstPaint--183661382184212409
backgroundConnect--291201763144240611
firstReactRender--23165672440
getState--18213883370188223
initialActions--103112
loadScripts--79968311541158221086
setupStore--1894681939
numNetworkReqs--59371682461118
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--8046501193918471009
load--64157988464689764
domContentLoaded--63657488064685751
domInteractive--2515110192279
firstPaint--1055932150139214
backgroundConnect--2851223138105
firstReactRender--16103951726
getState--3215134184162
initialActions--104112
loadScripts--63357287762683743
setupStore--1152851224
numNetworkReqs--181178181167
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13501004214625314521884
load--68359994180693898
domContentLoaded--67359293280680892
domInteractive--35181432932121
firstPaint--1346442580150328
backgroundConnect--93863618420579
firstReactRender--23173632529
getState--1507321116158179
initialActions--102111
loadScripts--66959092278677882
setupStore--1894991844
numNetworkReqs--994024046136218
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13831080240021914691775
load--1103923203216511631318
domContentLoaded--1102922203216511581318
domInteractive--71328728786134
firstPaint--------
backgroundConnect--55191944674174
firstReactRender--1394351322
getState--1257781323
initialActions--103122
loadScripts--1068907194414911191227
setupStore--144111141146
numNetworkReqs--19980191376
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25081839506355925153992
load--1247964268634612252194
domContentLoaded--1246964268634612242193
domInteractive--1112348778115315
firstPaint--------
backgroundConnect--105241156121108271
firstReactRender--23156782532
getState--26243984220316803
initialActions--207123
loadScripts--1200948261731211951992
setupStore--1216738155117531
numNetworkReqs--61292745070169
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15791250240722716562033
load--13111102167912613951538
domContentLoaded--13111101167912613951538
domInteractive--792817838118142
firstPaint--------
backgroundConnect--66203305581214
firstReactRender--14112631520
getState--2082293315111
initialActions--103122
loadScripts--12741052164711413551461
setupStore--204207351377
numNetworkReqs--19981191478
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29201996624585131874956
load--16141123315452916662955
domContentLoaded--16141122315452916662955
domInteractive--1013061692100269
firstPaint--------
backgroundConnect--1882311722711891127
firstReactRender--2616115142844
getState--31268929250460851
initialActions--213123
loadScripts--15001108313340215532638
setupStore--114674816089594
numNetworkReqs--58281703490130
19--------
📊 Page Load Benchmark Results

Current Commit: a2df3fd | Date: 1/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±35ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 707ms (±33ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 35ms 1.01s 1.30s 1.07s 1.30s
domContentLoaded 707ms 33ms 686ms 947ms 727ms 947ms
firstPaint 76ms 12ms 60ms 168ms 88ms 168ms
firstContentfulPaint 76ms 12ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 54 Bytes (0%)
  • common: 652 Bytes (0.01%)

Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 13, 2026

Builds ready [c2d9bdc]
UI Startup Metrics (1326 ± 121 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13261071169212113881587
load--1105890146811411661341
domContentLoaded--1099884146411411591325
domInteractive--291798212488
firstPaint--198661359230210913
backgroundConnect--22420425710228247
firstReactRender--15103641625
getState--3415110133958
initialActions--108112
loadScripts--88267812481139461095
setupStore--1164241215
numNetworkReqs--171177171169
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19161647243818720302325
load--1034891139911510651308
domContentLoaded--1020881137911510521298
domInteractive--36181502634107
firstPaint--214761392179239378
backgroundConnect--261202631105239601
firstReactRender--22163032428
getState--17613527428195225
initialActions--103112
loadScripts--80768111691128241084
setupStore--1784971839
numNetworkReqs--58361422461126
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--793655108184849934
load--63657582664661794
domContentLoaded--63256981963656787
domInteractive--2515103192282
firstPaint--1016029851125208
backgroundConnect--2951243148102
firstReactRender--16103551728
getState--3214129174259
initialActions--105112
loadScripts--62856681062654778
setupStore--1175161222
numNetworkReqs--181078181170
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1354993213224414181864
load--69659998086718888
domContentLoaded--68659397586711883
domInteractive--36171403034123
firstPaint--15265926110199338
backgroundConnect--103764819424589
firstReactRender--23173542532
getState--15913431727163215
initialActions--102011
loadScripts--68359096784706875
setupStore--1694861730
numNetworkReqs--60371492563131
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13621049200718315121645
load--1089893148012211641319
domContentLoaded--1088893148012211641318
domInteractive--73312144292150
firstPaint--------
backgroundConnect--56183465466172
firstReactRender--12102321316
getState--125112121027
initialActions--103112
loadScripts--1054880145710411171280
setupStore--133145161141
numNetworkReqs--19989201474
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25491954483263224954119
load--13021011276240712622568
domContentLoaded--13021010276240712622567
domInteractive--12735967131117405
firstPaint--------
backgroundConnect--117231054166105343
firstReactRender--23166282433
getState--24463871212334698
initialActions--217123
loadScripts--1256983270036612422360
setupStore--13810733173121589
numNetworkReqs--59291924274179
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16141302212616217101929
load--13491175172811014191550
domContentLoaded--13491174172811114191550
domInteractive--842624242112148
firstPaint--------
backgroundConnect--64182214575154
firstReactRender--16113041724
getState--199189241649
initialActions--102122
loadScripts--1311115315779413741497
setupStore--174136191658
numNetworkReqs--19982181474
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29212117736292629814571
load--16671150598878316012991
domContentLoaded--16671150598878316012990
domInteractive--126321002160104373
firstPaint--------
backgroundConnect--1912714232881501126
firstReactRender--24166872733
getState--27480938220385780
initialActions--208123
loadScripts--15861132595374115532838
setupStore--12610745180112605
numNetworkReqs--58292054748189
19--------
📊 Page Load Benchmark Results

Current Commit: c2d9bdc | Date: 1/13/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±42ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 718ms (±38ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 42ms 1.00s 1.35s 1.07s 1.35s
domContentLoaded 718ms 38ms 692ms 1.00s 756ms 1.00s
firstPaint 75ms 11ms 56ms 164ms 84ms 164ms
firstContentfulPaint 75ms 11ms 56ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 54 Bytes (0%)
  • common: 20 Bytes (0%)

@dan437 dan437 added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit c9346b5 Jan 13, 2026
213 of 228 checks passed
@dan437 dan437 deleted the queued-transactions-fix branch January 13, 2026 11:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
@metamaskbot metamaskbot added the release-13.15.0 Issue or pull request that will be included in release 13.15.0 label Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.15.0 Issue or pull request that will be included in release 13.15.0 size-M team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: - Queuing - MM breaks with the error Minified React error after queuing tx's and signatures from 2 different dapps

5 participants