-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: init perpsEnabled feature flag #39145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +14 -0)
👨🔧 @MetaMask/core-extension-ux (1 files, +14 -0)
👨🔧 @MetaMask/perps (3 files, +152 -1)
|
Builds ready [2e61495]
UI Startup Metrics (1264 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
ui/components/multichain/account-overview/account-overview-tabs.tsx
Outdated
Show resolved
Hide resolved
ui/components/multichain/account-overview/account-overview-tabs.tsx
Outdated
Show resolved
Hide resolved
Builds ready [cb91c53]
UI Startup Metrics (1338 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
aganglada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably add a minimumVersion to the FF so we can keep shipping in main until we reach the release version
Good idea. Updated the code to read from the newly created |
Builds ready [4c5dbfe]
UI Startup Metrics (1261 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gantunesr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for Accounts CO,
account-overview-tabs.tsx
Description
Initializes
perpsEnabledVersionfeature flag selector to gate Perps features behind during development, which is version gated to v13.15.0 at the time of this PR.Changelog
CHANGELOG entry: Add
perpsEnabledVersionfeature flagRelated issues
Fixes:
Manual testing steps
perpsEnabledfeature flag in main-dev environmentCurrently this only gates the Perps tab from showing up as an initial PoC
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds infrastructure to gate Perps via remote feature flags with version checks and wires it into the UI.
isPerpsFeatureEnabledhelper (semver-based using app version) andPerpsFeatureFlagtype; comprehensive unit testsgetIsPerpsEnabledreadsremoteFeatureFlags.perpsEnabledVersion; tests includedPerpstab when enabledAccountOverviewTabKey.Perps,TraceName.AccountOverviewPerpsTab,MetaMetricsEventName.PerpsScreenOpenedperpsWritten by Cursor Bugbot for commit 4c5dbfe. This will update automatically on new commits. Configure here.