Skip to content

Conversation

@ameliejyc
Copy link
Contributor

@ameliejyc ameliejyc commented Jan 12, 2026

Description

The dapp permission network selector and portfolio network filter should be decoupled. Currently selecting the former results in the latter updating. This PR removes that behaviour.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Portfolio network filter no longer changes when dapp permission network is changed

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-859

Manual testing steps

  1. Connect to a dapp
  2. Click the dapp icon next to the hamburger menu
  3. Click the network name
  4. Select a different EVM or non-EVM network
  5. Check that the portfolio (global) network filter has not changed from what it was before

Screenshots/Recordings

Note that there are other bugs seen in these recordings. One of them (the network list not showing the correct selected network) is fixed here.

Before

dapp.permissions.network.affects.global.network.filter.mov

After

dapp.permissions.global.network.filter.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Decouples dapp permission network selection from the global enabled networks state.

  • In network-list-menu.tsx, removes setEnabledNetworks import and dispatches from both EVM (handleEvmNetworkChange) and non-EVM (handleNonEvmNetworkChange) paths
  • Network switching still updates active network, nonce, NFT detection, and portfolio token filter logic, but no longer modifies the enabled networks list

Written by Cursor Bugbot for commit 2052563. This will update automatically on new commits. Configure here.

@ameliejyc ameliejyc requested a review from a team as a code owner January 12, 2026 14:07
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Jan 12, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 12, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +0 -6)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 network-list-menu/
          • 📄 network-list-menu.tsx +0 -6

…ter-when-switching-dapp-permissioned-network
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 12, 2026

Builds ready [d8c2ecd]
UI Startup Metrics (1307 ± 119 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13071048170911913651521
load--1098880147611511571325
domContentLoaded--1091871146911611511318
domInteractive--2715104192383
firstPaint--164641219160188308
backgroundConnect--22120127212226247
firstReactRender--15103341725
getState--3618124144167
initialActions--104112
loadScripts--87766512401159451096
setupStore--1172631316
numNetworkReqs--171180171166
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19021550261018719762341
load--1030880139811310571318
domContentLoaded--1017872138911310431311
domInteractive--3518239313194
firstPaint--189691410187225384
backgroundConnect--277201651125241619
firstReactRender--22153942427
getState--18313872361196242
initialActions--102112
loadScripts--80467711801138251101
setupStore--1764471836
numNetworkReqs--58341472261114
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--804667111879845944
load--64858088268675793
domContentLoaded--64357587267672785
domInteractive--261698182279
firstPaint--976037147102186
backgroundConnect--3161613739108
firstReactRender--16113941825
getState--3315154244057
initialActions--105112
loadScripts--64057386266669783
setupStore--1253961422
numNetworkReqs--171176161167
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1327992204624714411944
load--680591103288703885
domContentLoaded--670585102588692877
domInteractive--34171392832117
firstPaint--1376341677181332
backgroundConnect--91758417822550
firstReactRender--22164442428
getState--15313123922158213
initialActions--103111
loadScripts--667583101486690869
setupStore--1764581836
numNetworkReqs--59381492758136
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13751091216220914841812
load--1107929183915911941465
domContentLoaded--1107929183916011911464
domInteractive--74322294794170
firstPaint--------
backgroundConnect--56202965462169
firstReactRender--1395151218
getState--12691111326
initialActions--103122
loadScripts--1074914181814611361311
setupStore--134193191128
numNetworkReqs--20991201378
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25641853541163925544239
load--12981042294040912802617
domContentLoaded--12981042294040912802616
domInteractive--1113537571117301
firstPaint--------
backgroundConnect--139281466210124514
firstReactRender--23167682530
getState--29936929235466775
initialActions--208123
loadScripts--12431025274937112212588
setupStore--13510740185115662
numNetworkReqs--58302084358182
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15601281213217916711894
load--13131136160711113851554
domContentLoaded--13131136160711113851554
domInteractive--762724343100147
firstPaint--------
backgroundConnect--60182704671161
firstReactRender--15105851520
getState--1981462615115
initialActions--103122
loadScripts--1276112215449813391471
setupStore--195161251575
numNetworkReqs--19985191377
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--296620089842104330514813
load--16801233691777016383030
domContentLoaded--16801233691677016383030
domInteractive--11430741113108349
firstPaint--------
backgroundConnect--1952915812951591097
firstReactRender--2716192222750
getState--319701281256498827
initialActions--207123
loadScripts--15611180577262015312754
setupStore--13971145205117709
numNetworkReqs--58291974647190
19--------
📊 Page Load Benchmark Results

Current Commit: d8c2ecd | Date: 1/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±51ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±44ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 83ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 51ms 967ms 1.33s 1.11s 1.33s
domContentLoaded 723ms 44ms 670ms 1.00s 776ms 1.00s
firstPaint 83ms 12ms 64ms 176ms 96ms 176ms
firstContentfulPaint 83ms 12ms 64ms 176ms 96ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: -61 Bytes (0%)
  • common: 20 Bytes (0%)

@ameliejyc ameliejyc added this pull request to the merge queue Jan 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 12, 2026
@ameliejyc ameliejyc enabled auto-merge January 12, 2026 21:19
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 12, 2026

Builds ready [d8c2ecd]
UI Startup Metrics (1307 ± 119 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13071048170911913651521
load--1098880147611511571325
domContentLoaded--1091871146911611511318
domInteractive--2715104192383
firstPaint--164641219160188308
backgroundConnect--22120127212226247
firstReactRender--15103341725
getState--3618124144167
initialActions--104112
loadScripts--87766512401159451096
setupStore--1172631316
numNetworkReqs--171180171166
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19021550261018719762341
load--1030880139811310571318
domContentLoaded--1017872138911310431311
domInteractive--3518239313194
firstPaint--189691410187225384
backgroundConnect--277201651125241619
firstReactRender--22153942427
getState--18313872361196242
initialActions--102112
loadScripts--80467711801138251101
setupStore--1764471836
numNetworkReqs--58341472261114
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--804667111879845944
load--64858088268675793
domContentLoaded--64357587267672785
domInteractive--261698182279
firstPaint--976037147102186
backgroundConnect--3161613739108
firstReactRender--16113941825
getState--3315154244057
initialActions--105112
loadScripts--64057386266669783
setupStore--1253961422
numNetworkReqs--171176161167
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1327992204624714411944
load--680591103288703885
domContentLoaded--670585102588692877
domInteractive--34171392832117
firstPaint--1376341677181332
backgroundConnect--91758417822550
firstReactRender--22164442428
getState--15313123922158213
initialActions--103111
loadScripts--667583101486690869
setupStore--1764581836
numNetworkReqs--59381492758136
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13751091216220914841812
load--1107929183915911941465
domContentLoaded--1107929183916011911464
domInteractive--74322294794170
firstPaint--------
backgroundConnect--56202965462169
firstReactRender--1395151218
getState--12691111326
initialActions--103122
loadScripts--1074914181814611361311
setupStore--134193191128
numNetworkReqs--20991201378
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25641853541163925544239
load--12981042294040912802617
domContentLoaded--12981042294040912802616
domInteractive--1113537571117301
firstPaint--------
backgroundConnect--139281466210124514
firstReactRender--23167682530
getState--29936929235466775
initialActions--208123
loadScripts--12431025274937112212588
setupStore--13510740185115662
numNetworkReqs--58302084358182
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15601281213217916711894
load--13131136160711113851554
domContentLoaded--13131136160711113851554
domInteractive--762724343100147
firstPaint--------
backgroundConnect--60182704671161
firstReactRender--15105851520
getState--1981462615115
initialActions--103122
loadScripts--1276112215449813391471
setupStore--195161251575
numNetworkReqs--19985191377
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--296620089842104330514813
load--16801233691777016383030
domContentLoaded--16801233691677016383030
domInteractive--11430741113108349
firstPaint--------
backgroundConnect--1952915812951591097
firstReactRender--2716192222750
getState--319701281256498827
initialActions--207123
loadScripts--15611180577262015312754
setupStore--13971145205117709
numNetworkReqs--58291974647190
19--------
📊 Page Load Benchmark Results

Current Commit: d8c2ecd | Date: 1/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±51ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±44ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 83ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 51ms 967ms 1.33s 1.11s 1.33s
domContentLoaded 723ms 44ms 670ms 1.00s 776ms 1.00s
firstPaint 83ms 12ms 64ms 176ms 96ms 176ms
firstContentfulPaint 83ms 12ms 64ms 176ms 96ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: -61 Bytes (0%)
  • common: 20 Bytes (0%)

…ter-when-switching-dapp-permissioned-network
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 13, 2026

Builds ready [2052563]
UI Startup Metrics (1269 ± 107 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--12691029158610713421452
load--106087113669811221221
domContentLoaded--105386613609811171216
domInteractive--2516100182177
firstPaint--1406733063184268
backgroundConnect--21019625010213230
firstReactRender--1694261729
getState--3617162164154
initialActions--103112
loadScripts--8516671149989171008
setupStore--1263541319
numNetworkReqs--171177161163
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19501626261422819922463
load--1055916162513110991339
domContentLoaded--1043907160513210891328
domInteractive--38182463334107
firstPaint--202701309145231450
backgroundConnect--281210746131251619
firstReactRender--22163642428
getState--17213927025184222
initialActions--103112
loadScripts--82469313881288371081
setupStore--18117691839
numNetworkReqs--60372353062124
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--805661118984829953
load--64257996666656794
domContentLoaded--63757496166652790
domInteractive--2716133212285
firstPaint--1026034255103222
backgroundConnect--3251343346107
firstReactRender--16113241623
getState--3614132204667
initialActions--103111
loadScripts--63457295265649782
setupStore--1364481335
numNetworkReqs--181178171168
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1269962187122314191687
load--667587106282676865
domContentLoaded--658581105682667858
domInteractive--35171763232125
firstPaint--1366237171183283
backgroundConnect--92763818419555
firstReactRender--22183132429
getState--14512422216153172
initialActions--104111
loadScripts--655579104781664849
setupStore--1565071534
numNetworkReqs--1044130551140219
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13681075210519314891770
load--1086921153512111721285
domContentLoaded--1085921153512111721285
domInteractive--63312404085139
firstPaint--------
backgroundConnect--53201744071139
firstReactRender--1292321217
getState--12587101130
initialActions--102112
loadScripts--1051906151310611091212
setupStore--194831821129
numNetworkReqs--20981191375
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--24851803519453025383829
load--1220981270029112002002
domContentLoaded--1219981270029111992002
domInteractive--11634973117112310
firstPaint--------
backgroundConnect--127241062187114346
firstReactRender--241577102534
getState--28065882232427766
initialActions--217123
loadScripts--1170961268126011641609
setupStore--1265766171115578
numNetworkReqs--60292824478153
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15351301216516416151879
load--12971117159110513631536
domContentLoaded--12971113159110513631535
domInteractive--76271543697141
firstPaint--------
backgroundConnect--53182103656144
firstReactRender--15102531623
getState--2282203418104
initialActions--103122
loadScripts--1266109515659713271448
setupStore--166124181543
numNetworkReqs--20987191575
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--28462225613970128274566
load--15731236321447815722913
domContentLoaded--15731235321347815722913
domInteractive--134301017167111515
firstPaint--------
backgroundConnect--127271077136138404
firstReactRender--24175052734
getState--32388892247506812
initialActions--218123
loadScripts--15111218319241515162609
setupStore--961076313097476
numNetworkReqs--58282004747194
19--------
📊 Page Load Benchmark Results

Current Commit: 2052563 | Date: 1/13/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±41ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 746ms (±37ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 41ms 1.03s 1.35s 1.10s 1.35s
domContentLoaded 746ms 37ms 714ms 1.01s 774ms 1.01s
firstPaint 77ms 11ms 60ms 168ms 84ms 168ms
firstContentfulPaint 77ms 11ms 60ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: -61 Bytes (0%)
  • common: 20 Bytes (0%)

@ameliejyc ameliejyc added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 8fba051 Jan 13, 2026
178 checks passed
@ameliejyc ameliejyc deleted the CEUX-859-do-not-switch-portfolio-network-filter-when-switching-dapp-permissioned-network branch January 13, 2026 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
@metamaskbot metamaskbot added the release-13.15.0 Issue or pull request that will be included in release 13.15.0 label Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.15.0 Issue or pull request that will be included in release 13.15.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants