-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: do not set portfolio network filter on dapp permission network change #39181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ameliejyc
merged 4 commits into
main
from
CEUX-859-do-not-switch-portfolio-network-filter-when-switching-dapp-permissioned-network
Jan 13, 2026
Merged
chore: do not set portfolio network filter on dapp permission network change #39181
ameliejyc
merged 4 commits into
main
from
CEUX-859-do-not-switch-portfolio-network-filter-when-switching-dapp-permissioned-network
Jan 13, 2026
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion network change
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +0 -6)
|
…ter-when-switching-dapp-permissioned-network
Contributor
Builds ready [d8c2ecd]
UI Startup Metrics (1307 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
approved these changes
Jan 12, 2026
AndyMBridges
approved these changes
Jan 12, 2026
Contributor
Builds ready [d8c2ecd]
UI Startup Metrics (1307 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
approved these changes
Jan 12, 2026
…ter-when-switching-dapp-permissioned-network
Contributor
Builds ready [2052563]
UI Startup Metrics (1269 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.15.0
Issue or pull request that will be included in release 13.15.0
size-XS
team-core-extension-ux
Core Extension UX team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dapp permission network selector and portfolio network filter should be decoupled. Currently selecting the former results in the latter updating. This PR removes that behaviour.
Changelog
CHANGELOG entry: Portfolio network filter no longer changes when dapp permission network is changed
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-859
Manual testing steps
Screenshots/Recordings
Note that there are other bugs seen in these recordings. One of them (the network list not showing the correct selected network) is fixed here.
Before
dapp.permissions.network.affects.global.network.filter.mov
After
dapp.permissions.global.network.filter.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Decouples dapp permission network selection from the global enabled networks state.
network-list-menu.tsx, removessetEnabledNetworksimport and dispatches from both EVM (handleEvmNetworkChange) and non-EVM (handleNonEvmNetworkChange) pathsWritten by Cursor Bugbot for commit 2052563. This will update automatically on new commits. Configure here.