-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: Perps Tab View - static #39199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +2 -1)
👨🔧 @MetaMask/core-extension-ux (1 files, +2 -1)
👨🔧 @MetaMask/perps (26 files, +2517 -1)
|
Builds ready [6c4b806]
UI Startup Metrics (1262 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Builds ready [5737a56]
UI Startup Metrics (1280 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
geositta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added a few comments for us to consider in future PRs. Thanks for adding the Tailwind utility classes. I think that will be better quality of life instead of defining SCSS basic classes.
Builds ready [1d41b05]
UI Startup Metrics (1311 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [488d672]
UI Startup Metrics (1346 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
geositta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the extra time with those formatters, looks good to me.
ccharly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for accounts
Description
Context
This PR introduces the initial UI components for the Perps (perpetuals trading) tab in the MetaMask extension. The Perps feature will allow users to view their perpetual trading positions and orders directly within the wallet.
Problem
As we migrate the Perps trading feature to the extension, we need to establish the UI foundation before integrating with live data. This ensures the design can be reviewed and signed off while backend work continues in parallel.
Solution
This PR implements the Perps tab UI with static mock data. The components are built following MetaMask design system patterns and are ready for live data integration in a future PR.
Changelog
CHANGELOG entry: Initialize static perps tab UI
Related issues
Fixes:
Manual testing steps
Perps tab should not be visible if perpsEnabledVersion ff is false.
Screenshots/Recordings
Screen.Recording.2026-01-12.at.1.44.29.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces the initial Perps trading UI with static data and hooks it into the account overview.
PerpsTabView,PerpsTabControlBar,PositionCard,OrderCard,PerpsTokenLogo,PerpsEmptyState,StartTradeCta, sharedutils,constants, and typed models intypesmocks.ts(no backend wiring yet)account-overview-tabs.tsxto renderPerpsTabViewwhen feature flag is enabledapp/_locales/en*/messages.jsonWritten by Cursor Bugbot for commit 488d672. This will update automatically on new commits. Configure here.