Skip to content

Conversation

@vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Jan 21, 2026

Description

The info icon next to the Additional networks label is too small, wrong color and not centered

Open in GitHub Codespaces

Changelog

CHANGELOG entry:null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MDP-668

Manual testing steps

  1. Go to this the network picker
  2. Scroll down to Additional Networks
  3. Observe change

Screenshots/Recordings

before after
before after

Before

~

After

~

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refines the layout and styling of the Additional Networks info icon.

  • Switches container from InlineFlex to Flex with centered alignItems/justifyContent for proper alignment
  • Updates info icon to size=Md and color=iconAlternative; removes top margin and wraps in centered Box
  • Imports AlignItems; adjusts related props and updates snapshot

Written by Cursor Bugbot for commit 8e0b885. This will update automatically on new commits. Configure here.

@vinnyhoward vinnyhoward requested a review from a team as a code owner January 21, 2026 21:40
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Jan 21, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 21, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +17 -7)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 network-manager/
          • 📁 components/
            • 📁 additional-networks-info/
              • 📁 __snapshots__/
                • 📄 additional-networks-info.test.tsx.snap +3 -3
                • 📄 additional-networks-info.tsx +14 -4

@vinnyhoward vinnyhoward changed the title fix: align additional networks info icon (MDP-668) fix: align additional networks info icon Jan 21, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 21, 2026

Builds ready [8e0b885]
UI Startup Metrics (1299 ± 101 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--12991046159410113611450
load--108488213249611511244
domContentLoaded--107887513159511441230
domInteractive--2615106192293
firstPaint--150671035134173296
backgroundConnect--21619626211221240
firstReactRender--15103451727
getState--3514127133756
initialActions--105113
loadScripts--8686751119949331026
setupStore--1377381426
numNetworkReqs--171176161164
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--18601438248417219492228
load--1023906161612010541290
domContentLoaded--1010899159912010331278
domInteractive--34171422829115
firstPaint--195681613199228342
backgroundConnect--281206721134237615
firstReactRender--22155972238
getState--17512775464185228
initialActions--104112
loadScripts--79768113851198181068
setupStore--1884571939
numNetworkReqs--58361422361115
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--816666110086858992
load--66158385974700815
domContentLoaded--65657985373697811
domInteractive--2615102212291
firstPaint--1006130150107200
backgroundConnect--205116222889
firstReactRender--17113451827
getState--3516144174462
initialActions--105112
loadScripts--65357785172695802
setupStore--1253861324
numNetworkReqs--171177171165
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1256986211124713781911
load--660584105083678848
domContentLoaded--650578104684665842
domInteractive--33171642732107
firstPaint--1276232165169252
backgroundConnect--48755412218526
firstReactRender--22174742432
getState--16014124417167187
initialActions--103111
loadScripts--648576103983663835
setupStore--1885491841
numNetworkReqs--1053823343118218
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14551173213318915431868
load--1166986172912912301395
domContentLoaded--1165986172913012301395
domInteractive--72322324095140
firstPaint--------
backgroundConnect--66223756267179
firstReactRender--14104351424
getState--1163851320
initialActions--103122
loadScripts--1130972168212011811358
setupStore--185227291354
numNetworkReqs--18977171370
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25261890543970124894136
load--12841006283740612142599
domContentLoaded--12831006283740712132599
domInteractive--1103651588110356
firstPaint--------
backgroundConnect--134251241202111483
firstReactRender--22156582428
getState--27864938228400748
initialActions--213123
loadScripts--1213983262333511552057
setupStore--1211174416899611
numNetworkReqs--5230102217890
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15261298193214316081805
load--13001107161810313541505
domContentLoaded--13001107161810313541505
domInteractive--802621142128141
firstPaint--------
backgroundConnect--57182504366145
firstReactRender--14112421419
getState--167132211440
initialActions--103122
loadScripts--1266109415969213111454
setupStore--165159251231
numNetworkReqs--19980181370
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29372165795289129794689
load--16671222649672516653177
domContentLoaded--16671221649672516643177
domInteractive--1062869490111302
firstPaint--------
backgroundConnect--1942211542682051025
firstReactRender--2417141132530
getState--28473856225471749
initialActions--2034323
loadScripts--15771199632165716113023
setupStore--891175413282380
numNetworkReqs--513094197384
19--------
📊 Page Load Benchmark Results

Current Commit: 8e0b885 | Date: 1/21/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±34ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 38ms 1.01s 1.31s 1.07s 1.31s
domContentLoaded 724ms 34ms 700ms 977ms 751ms 977ms
firstPaint 77ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 77ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 151 Bytes (0%)
  • common: 20 Bytes (0%)

@vinnyhoward vinnyhoward added this pull request to the merge queue Jan 22, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2026
@vinnyhoward vinnyhoward added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 0dd262c Jan 22, 2026
363 of 365 checks passed
@vinnyhoward vinnyhoward deleted the fix-mdp-668-network-menu-icon branch January 22, 2026 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2026
@metamaskbot metamaskbot added the release-13.16.0 Issue or pull request that will be included in release 13.16.0 label Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.16.0 Issue or pull request that will be included in release 13.16.0 size-S team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants