fix: cp-13.14.2 Guard against invalid controller state #39465
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the `setupController` method in `background.js`, it will throw an error during initialization if any "controllers with persisted state" have something other than an object as their state (e.g. `undefined` or `null` or a primitive). This should be impossible due to type checks, but we're seeing it happen anyway. This code has been updated to report the error and continue initialization without interruption. There is still a root cause here to fix, but we can address that in a follow-up PR (it may take more time to learn what the root cause is). Fixes #39464
Contributor
Builds ready [d7f9f88]
UI Startup Metrics (1242 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
davidmurdoch
approved these changes
Jan 22, 2026
Contributor
davidmurdoch
left a comment
davidmurdoch
left a comment
There was a problem hiding this comment.
Manually tested and can confirm that it fixes the issue.
Gudahtt
changed the title
Contributor
Builds ready [217ff83]
UI Startup Metrics (1275 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
sleepytanya
approved these changes
Jan 22, 2026
MajorLift
approved these changes
Jan 22, 2026
Gudahtt
added a commit
that referenced
this pull request
Jan 22, 2026
This PR updates the change log for 13.14.2. (Hotfix - no test plan generated.) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates release notes. > > - Adds `13.14.2` section with a fix: prevent crash during initialization when a controller has invalid state (#39465) > - Updates `[Unreleased]` compare link to start from `v13.14.2` and adds `[13.14.2]` compare reference > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d8bca06. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: metamaskbot <[email protected]> Co-authored-by: Mark Stacey <[email protected]>
metamaskbot
added
the
release-13.16.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the
setupControllermethod inbackground.js, it will throw an error during initialization if any "controllers with persisted state" have something other than an object as their state (e.g.undefinedornullor a primitive). This should be impossible due to type checks, but we're seeing it happen anyway.This code has been updated to report the error and continue initialization without interruption. There is still a root cause here to fix, but we can address that in a follow-up PR (it may take more time to learn what the root cause is).
Changelog
CHANGELOG entry: Prevent crash during initialization when some controller has invalid state.
Related issues
Fixes #39464
Manual testing steps
loading.htmlpageloading.htmlagain, and runawait chrome.storage.local.get()to confirm that the state was set correctly (fooandbarshould be present). If not, try again.Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Prevents initialization from crashing when a controller has invalid (non-object) state by reporting and skipping it.
captureExceptionimportsetupController(inbackground.js), guards each controller state: ifnullor not an object, report viacaptureExceptionand continue; otherwise proceed with change detection/persistenceWritten by Cursor Bugbot for commit 217ff83. This will update automatically on new commits. Configure here.