chore: Update Earn controller to resolve peer dependency warnings #20044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
the
No QA Needed
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
2b5fb75 to
d262e94
Compare
4 tasks
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
d262e94 to
a4076f2
Compare
Gudahtt
added a commit
to MetaMask/core
that referenced
this pull request
Sep 22, 2025
## Explanation Our constraints for `peerDependencies` previously only required the major version to match. However, this was problematic for pre-1.0 packages because it allowed for situations where we cannot update a package without introducing a peer dependency error, since pre-1.0 packages can have breaking changes in minor or patch releases. The constraint has been updated to require the most significant part of the version to be synchronized for peer dependencies, and all resulting constraint errors have been auto-fixed. ## References N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes - Extension: MetaMask/metamask-extension#36093 - Mobile: MetaMask/metamask-mobile#20044
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
a4076f2 to
1020cdd
Compare
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
1020cdd to
4fefbad
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
34197fe to
3dcd907
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20044 +/- ##
==========================================
+ Coverage 76.54% 76.55% +0.01%
==========================================
Files 3316 3318 +2
Lines 80628 80728 +100
Branches 14716 14742 +26
==========================================
+ Hits 61714 61804 +90
+ Misses 14864 14863 -1
- Partials 4050 4061 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I've discovered there may have been additional breaking changes included in the two bridge packages. Moving to draft until we can get clarification. |
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
fc7953a to
d881d4b
Compare
Member
Author
The unintended breaking changes have now been removed with the latest versions of the two bridge controller packages |
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
d881d4b to
7a632bd
Compare
Member
Author
|
Rebased to resolve conflicts |
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
b765f9b to
639fc9f
Compare
Gudahtt
commented
Sep 24, 2025
Member
Author
There was a problem hiding this comment.
This change is included in v44.1.0, which we're updating to here
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
2 times, most recently
from
f829a83 to
170def8
Compare
Member
Author
|
Rebased to resolve conflicts again |
weitingsun
previously approved these changes
Sep 24, 2025
Gudahtt
force-pushed
the
resolve-pre-1.0-peer-dependency-warnings
branch
from
170def8 to
a42066a
Compare
Gudahtt
changed the title
|
metamaskbot
added
the
release-7.58.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update a variety of packages that are part of the
coremonorepo which had peer dependency warnings. The only breaking changes here are the peer dependencies, which should now be aligned.Edit: Other packages were updated in separate PRs, this now only updates the EarnController.
Package changelog:
earn-controller: 8.0.0Changelog
CHANGELOG entry: null
Related issues
Here is the corresponding core PR: MetaMask/core#6652
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Update @metamask/earn-controller to ^8.0.0 and align related peer/transitive dependencies.
@metamask/earn-controllerto^8.0.0inpackage.json.yarn.lock:@metamask/base-controller@^8.4.0,@metamask/controller-utils@^11.14.0,@metamask/keyring-api@^21.0.0, peer@metamask/account-tree-controller@^1.0.0.Written by Cursor Bugbot for commit a42066a. This will update automatically on new commits. Configure here.