-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Implement expo-font for improved font rendering and maintainability #22217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
792ecef to
5aebd6b
Compare
d85ece4 to
08069ee
Compare
16f2591 to
1d0e10e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22217 +/- ##
==========================================
+ Coverage 77.91% 78.02% +0.10%
==========================================
Files 3852 3865 +13
Lines 98566 98951 +385
Branches 19374 19466 +92
==========================================
+ Hits 76801 77205 +404
+ Misses 16501 16439 -62
- Partials 5264 5307 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
f4cbc4a to
d0acded
Compare
|
Caution MetaMask internal reviewing guidelines:
|
… existing setups and not relying on npx expo prebuild
f66efff to
1565d6e
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR migrates the font system from space-separated font names (e.g., "Geist Regular") to PostScript names with hyphens (e.g., "Geist-Regular") for proper expo-font integration. Key changes include:
Risk Assessment:
Selected test tags cover:
Not selecting:
Confidence at 85% because:
|
|
Closing in favor of #23517 but keeping fontStyle updates for reference |


Description
This PR implements
expo-fontto improve font rendering and maintainability of fonts in MetaMask Mobile. The change provides several benefits:(from docs)
Key Changes
This PR is still in development. Additional work needed:
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Font References Audit
The following locations have independently defined font families that may need review:
Using old space-separated format (needs updating):
Using new hyphenated format (correct):
Platform-specific fonts:
Font weights found across codebase:
Common numeric weights: 400, 500, 600, 700, 800
String weights: 'bold', 'normal'
🤖 Generated with Claude Code