Skip to content

feat: import newremote feature flag controller with override functionality #23487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asalsys wants to merge 8 commits into
base: main
Choose a base branch
from
+228 −82
Draft

feat: import newremote feature flag controller with override functionality #23487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
579e947
import local remote feature flag
asalsys Dec 1, 2025
5587dfe
fix import issue and working remote-feature-flag-controller
asalsys Dec 2, 2025
369d995
support ab-test options
asalsys Dec 2, 2025
caaafbf
remove engine ready
asalsys Dec 4, 2025
06336f2
update abTestRawFlags to rawProcessedRemoteFeatureFlags
asalsys Dec 4, 2025
eee57f6
Merge branch 'main' into use-updated-remote-feature-flag-to-handle-ov…
asalsys Dec 11, 2025
4cdecbd
update the rawFeatureFlag options
asalsys Dec 11, 2025
79726ad
use preiview remote-feature-flag-controller
asalsys Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update the rawFeatureFlag options
  • Loading branch information
@asalsys
asalsys committed Dec 11, 2025
commit 4cdecbde037d93bb684c29fcf886331a1f8eb53c
10 changes: 4 additions & 6 deletions app/components/Views/FeatureFlagOverride/FeatureFlagOverride.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import {
import { useFeatureFlagOverride } from '../../../contexts/FeatureFlagOverrideContext';
import { useFeatureFlagStats } from '../../../hooks/useFeatureFlagStats';
import {
selectRawProcessedRemoteFeatureFlags,
selectrawRemoteFeatureFlags,
selectLocalOverrides,
} from '../../../selectors/featureFlagController';
import { useSelector } from 'react-redux';
Expand All @@ -45,9 +45,7 @@ export interface MinimumVersionFlagValue {
minimumVersion: string;
}
const FeatureFlagRow: React.FC<FeatureFlagRowProps> = ({ flag, onToggle }) => {
const rawProcessedRemoteFeatureFlags = useSelector(
selectRawProcessedRemoteFeatureFlags,
);
const rawRemoteFeatureFlags = useSelector(selectrawRemoteFeatureFlags);
const override = useSelector(selectLocalOverrides);
const tw = useTailwind();
const theme = useTheme();
Expand Down Expand Up @@ -137,9 +135,9 @@ const FeatureFlagRow: React.FC<FeatureFlagRowProps> = ({ flag, onToggle }) => {
value: unknown;
}
const abTestOptions: AbTestType[] = Array.isArray(
rawProcessedRemoteFeatureFlags[flag.key],
rawRemoteFeatureFlags[flag.key],
)
? (rawProcessedRemoteFeatureFlags[flag.key] as AbTestType[])
? (rawRemoteFeatureFlags[flag.key] as AbTestType[])
: [];
const flagValue = flag.value as AbTestType;

Expand Down
6 changes: 3 additions & 3 deletions app/selectors/featureFlagController/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type { RemoteFeatureFlagControllerState } from '@metamask/remote-feature-
interface ExtendedRemoteFeatureFlagControllerState
extends RemoteFeatureFlagControllerState {
localOverrides?: Record<string, unknown>;
rawProcessedRemoteFeatureFlags?: Record<string, unknown>;
rawRemoteFeatureFlags?: Record<string, unknown>;
}

// Access the controller state directly
Expand Down Expand Up @@ -48,10 +48,10 @@ export const selectLocalOverrides = createSelector(
)?.localOverrides ?? {},
);

export const selectRawProcessedRemoteFeatureFlags = createSelector(
export const selectrawRemoteFeatureFlags = createSelector(
selectRemoteFeatureFlagControllerState,
(remoteFeatureFlagControllerState: unknown) =>
(
remoteFeatureFlagControllerState as ExtendedRemoteFeatureFlagControllerState
)?.rawProcessedRemoteFeatureFlags ?? {},
)?.rawRemoteFeatureFlags ?? {},
);
12 changes: 6 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9035,21 +9035,21 @@ __metadata:
linkType: hard

"@metamask/remote-feature-flag-controller@file:/Users/sallem/Desktop/metamask/core/packages/remote-feature-flag-controller::locator=metamask%40workspace%3A.":
version: 2.0.1
resolution: "@metamask/remote-feature-flag-controller@file:/Users/sallem/Desktop/metamask/core/packages/remote-feature-flag-controller#/Users/sallem/Desktop/metamask/core/packages/remote-feature-flag-controller::hash=ce21bc&locator=metamask%40workspace%3A."
version: 3.0.0
resolution: "@metamask/remote-feature-flag-controller@file:/Users/sallem/Desktop/metamask/core/packages/remote-feature-flag-controller#/Users/sallem/Desktop/metamask/core/packages/remote-feature-flag-controller::hash=731dfb&locator=metamask%40workspace%3A."
dependencies:
"@metamask/base-controller": "npm:^9.0.0"
"@metamask/controller-utils": "npm:^11.16.0"
"@metamask/messenger": "npm:^0.3.0"
"@metamask/utils": "npm:^11.8.1"
uuid: "npm:^8.3.2"
checksum: 10/0dd9b350f281c088ac007dc54db482e775990dbe22df9fd97b548e82cf7af4bdc5d886347fa86165506426e978318e84aa040092bc8d91c3b8b5d9f937a1f7fc
checksum: 10/6528470a09a2c8cf6c14fc9f03a6b5577945ab28ad9105c4aa4816ea6edbdd84f570e737f49068559146f9c3bbe58843b570f8d5e174184288305aeb9b688455
languageName: node
linkType: hard

"@metamask/remote-feature-flag-controller@npm:^2.0.1":
version: 2.0.1
resolution: "@metamask/remote-feature-flag-controller@npm:2.0.1"
"@metamask/remote-feature-flag-controller@npm:^3.0.0":
version: 3.0.0
resolution: "@metamask/remote-feature-flag-controller@npm:3.0.0"
dependencies:
"@metamask/base-controller": "npm:^9.0.0"
"@metamask/controller-utils": "npm:^11.16.0"
Expand Down
Loading