Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 2, 2023

This is based on MetaMask/utils#144. Refer to that PR for the rationale behind it.

@Mrtenz Mrtenz requested a review from a team November 2, 2023 10:37
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tsup 7.2.0 eval, network, filesystem, shell, environment +40 211 MB egoist

🚮 Removed packages: @swc/[email protected], @swc/[email protected]

@socket-security
Copy link

socket-security bot commented Nov 2, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

FrederikBolding
FrederikBolding previously approved these changes Nov 2, 2023
@Mrtenz
Copy link
Member Author

Mrtenz commented Nov 2, 2023

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mrtenz Mrtenz merged commit 53f01f4 into main Nov 3, 2023
@Mrtenz Mrtenz deleted the mrtenz/tsup branch November 3, 2023 09:31
@mcmire mcmire mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants