Skip to content

Conversation

@mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 13, 2023

TypeScript excludes node_modules by default (among other directories) if you don't specify exclude in the TS config, but if you specify exclude, then you need to make to explicitly list node_modules.

Examples

I believe we have started adding this slowly as we've remembered, but here is the latest example: MetaMask/create-release-branch#93

TypeScript excludes `node_modules` by default (among other directories)
if you don't specify `exclude` in the TS config, but if you specify
`exclude`, then you need to make to explicitly list `node_modules`.
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 2d27b32 into main Nov 15, 2023
@mcmire mcmire deleted the exclude-node-modules-from-ts branch November 15, 2023 16:16
@mcmire mcmire mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants