Skip to content

Unvendor Yarn; favor Corepack for installation #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 2 commits into from
Jun 6, 2024
Merged

Unvendor Yarn; favor Corepack for installation #243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
663cdea
Unvendor Yarn; favor Corepack for installation
mcmire Apr 25, 2024
2cd37d1
ci: run `corepack enable` before installing dependencies (#244)
legobeat Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ci: run corepack enable before installing dependencies (#244) 
* ci: run `corepack enable` as part of prepare

* chore(ci): do redundant setup-node step before checkout to enable yarn v4 before deps install

- makes nodejs version `lts/*` explicit in ci workflow
  • Loading branch information
@legobeat
legobeat authored Apr 29, 2024
commit 2cd37d1f805b8280f4b3732dfd211cf9cfdb09e4
38 changes: 34 additions & 4 deletions .github/workflows/build-lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,17 @@ jobs:
name: Prepare
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version: 'lts/*'
- name: Install Yarn
run: corepack enable
- uses: actions/checkout@v4
- name: Use Node.js and install dependencies
uses: actions/setup-node@v4
with:
node-version: 'lts/*'
cache: 'yarn'
- name: Install Yarn dependencies
run: yarn --immutable
Expand All @@ -23,11 +29,17 @@ jobs:
needs:
- prepare
steps:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 'lts/*'
- name: Install Yarn
run: corepack enable
- uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version: 'lts/*'
cache: 'yarn'
- run: yarn --immutable --immutable-cache
- run: yarn build
Expand All @@ -45,11 +57,17 @@ jobs:
needs:
- prepare
steps:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 'lts/*'
- name: Install Yarn
run: corepack enable
- uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version: 'lts/*'
cache: 'yarn'
- run: yarn --immutable --immutable-cache
- run: yarn lint
Expand All @@ -76,6 +94,12 @@ jobs:
matrix:
node-version: [18.x, 20.x]
steps:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install Yarn
run: corepack enable
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
Expand All @@ -101,6 +125,12 @@ jobs:
matrix:
node-version: [18.x, 20.x]
steps:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install Yarn
run: corepack enable
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
Expand Down