-
Notifications
You must be signed in to change notification settings - Fork 86
Add GitHub Actions workflow for Webpack build #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| 'use client' | ||
|
|
||
| import { inject } from '@vercel/analytics' | ||
|
|
||
| export function Analytics() { | ||
| inject() | ||
| return null | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| 'use client' | ||
|
|
||
| import { inject } from '@vercel/analytics' | ||
|
|
||
| export function Analytics() { | ||
| inject() | ||
| return null | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| 'use client' | ||
|
|
||
| import { inject } from '@vercel/analytics' | ||
|
|
||
| export function Analytics() { | ||
| inject() | ||
| return null | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing useEffect causes inject to run every render
The
inject()function from@vercel/analyticsis called directly in the component body without being wrapped in auseEffecthook. This causes the analytics initialization to run on every render instead of only once when the component mounts. In React StrictMode (development mode), this will execute twice per mount, and any re-render of parent components will trigger additional calls. The same issue exists inquickstarts/wagmi/app/analytics.tsx.Additional Locations (2)
partners/web3auth/app/analytics.tsx#L4-L7quickstarts/next/app/analytics.tsx#L4-L7