fix: use randomly generated request id in windowPostMessageTransport and externallyConnectableTransport
#81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Previously, the transport initialized
requestIdto1and incremented it for each request. This caused issues when:1again)This PR updates
windowPostMessageTransportto usegetUniqueId()util function as the initial request ID instead of starting from1. This change is necessary to prevent said request ID conflicts across disconnect/reconnect cycles, particularly on Firefox.We also update
externallyConnectableTransportfor consistency.Note
Randomizes initial request IDs in windowPostMessageTransport and externallyConnectableTransport using getUniqueId, updating tests and changelog accordingly.
requestIdwithgetUniqueId()insrc/transports/windowPostMessageTransport.tsandsrc/transports/externallyConnectableTransport.tsto avoid ID collisions across reconnects.getUniqueId()insrc/helpers/utils.tsfor generating rollover-safe unique IDs.getUniqueId()and assert dynamic IDs inwindowPostMessageTransport.test.tsandexternallyConnectableTransport.test.ts.CHANGELOG.md.Written by Cursor Bugbot for commit 31accf1. This will update automatically on new commits. Configure here.