feat: add tron scope types #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
EdouardBougon
force-pushed
the
tron-types
branch
6 times, most recently
from
586db74 to
0d5ff1f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
EdouardBougon
force-pushed
the
tron-types
branch
from
e1bab96 to
80d4c05
Compare
| const transport = getDefaultTransport({ | ||
| warmupTimeout: 200, // 200 ms for the initial warmup request | ||
| defaultTimeout: -1 // No timeout for subsequent requests (user interactions) | ||
| }); |
There was a problem hiding this comment.
Bug: getDefaultTransport missing warmupTimeout parameter support
The README shows using getDefaultTransport({ warmupTimeout: 200, defaultTimeout: -1 }), but the getDefaultTransport function only accepts extensionId and defaultTimeout parameters. It doesn't destructure or pass warmupTimeout to the underlying transport functions (getExternallyConnectableTransport and getWindowPostMessageTransport), even though they support it. Users following the documentation will have warmupTimeout silently ignored.
Additional Locations (1)
EdouardBougon
force-pushed
the
tron-types
branch
from
c0a823e to
8edd12a
Compare
EdouardBougon
force-pushed
the
tron-types
branch
from
69d2c15 to
144c0cc
Compare
EdouardBougon
force-pushed
the
tron-types
branch
from
144c0cc to
9f6c2a2
Compare
baptiste-marchand
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds Tron RPC scope/types and exposes EIP-155 and session types; updates exports and adds tsd tests.
tronscope (types/scopes/tron.types.ts) withsignMessageandsignTransactionmethods; add toDefaultRpcApiintypes/scopes/index.ts.types/scopes/eip155.types.ts(e.g.,Transaction,Block,Log, etc.).CaipAccountId,CaipChainId; clarify session-related types intypes/session.ts.types/scopesfromsrc/index.ts.signMessageand importSignatureintests/index.test-d.ts.Written by Cursor Bugbot for commit 9f6c2a2. This will update automatically on new commits. Configure here.