fix: warmup timeout #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Features
Configurable Request Timeouts:
-1(no timeout) to accommodate user interactions-1explicitly disables timeoutWarmup Timeout: Added
warmupTimeoutparameter for the initial connection handshake200ms(defined inDEFAULT_WARMUP_TIMEOUT)wallet_getSessionrequest after connectionWhy These Changes?
User Interaction Support: Most Multichain API operations require user confirmation (e.g., signing transactions). The default
-1timeout prevents premature request cancellation.Initialization Reliability: The
warmupTimeoutaddresses a specific issue where the first request after connection may need extra time to complete (see MetaMask Mobile issue #16550).Flexibility: Developers can now configure timeouts based on their specific needs while maintaining sensible defaults.
Example Usage