Skip to content

chore: include regular tx events during the stx status changes #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikoferro wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: include regular tx events during the stx status changes #119

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
397aa0e
chore: include regular tx events during the stx status changes
nikoferro Feb 15, 2023
c7e94f5
chore: updated tests + increased coverage
nikoferro Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: updated tests + increased coverage
  • Loading branch information
@nikoferro
nikoferro committed Feb 15, 2023
commit c7e94f5f4a3d6089027c5f12c33106ec4644c15c
33 changes: 31 additions & 2 deletions src/SmartTransactionsController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,22 @@ describe('SmartTransactionsController', () => {
expect(trackMetaMetricsEventSpy).not.toHaveBeenCalled();
});

it('tracks status change if smartTransaction and prevSmartTransaction have different statuses', () => {
it('tracks status change if smartTransaction and prevSmartTransaction have different statuses and status is not pending', () => {
const smartTransaction = {
...createStateAfterPending()[0],
status: 'success',
swapMetaData: {},
};
const prevSmartTransaction = { ...smartTransaction, status: 'pending' };

smartTransactionsController.trackStxStatusChange(
smartTransaction as SmartTransaction,
prevSmartTransaction as SmartTransaction,
);
expect(trackMetaMetricsEventSpy).toHaveBeenCalledTimes(1);
});

it('tracks status change if smartTransaction and prevSmartTransaction and status is pending', () => {
const smartTransaction = {
...createStateAfterPending()[0],
swapMetaData: {},
Expand All @@ -409,7 +424,21 @@ describe('SmartTransactionsController', () => {
smartTransaction as SmartTransaction,
prevSmartTransaction as SmartTransaction,
);
expect(trackMetaMetricsEventSpy).toHaveBeenCalled();
expect(trackMetaMetricsEventSpy).toHaveBeenCalledTimes(2);
});

it('tracks status change if smartTransaction and prevSmartTransaction and status is cancelled', () => {
const smartTransaction = {
...createStateAfterPending()[0],
status: 'cancelled',
swapMetaData: {},
};
const prevSmartTransaction = { ...smartTransaction, status: 'pending' };
smartTransactionsController.trackStxStatusChange(
smartTransaction as SmartTransaction,
prevSmartTransaction as SmartTransaction,
);
expect(trackMetaMetricsEventSpy).toHaveBeenCalledTimes(2);
});
});

Expand Down