feat(STX-331): migrate STX flags to smart-transactions-controller

[rarquevaux]

RemoteFeatureFlagController Integration in SmartTransactionController

This PR refactors how Smart Transactions feature flags are validated and made available to clients. This will allow clients to move away from the smart transactions properties of the swaps feature flags which are deprecated.

Key Changes:

• Flag Source: Feature flags are now read directly from RemoteFeatureFlagController:getState instead of a getFeatureFlags callback.
• Validation Timing: Flags are validated when RemoteFeatureFlagController:stateChange fires
• Per-Chain Validation: Invalid chain configs are removed individually without affecting valid chains; errors are reported to Sentry via ErrorReportingService:captureException
• Unknown Chain Safety: Chains without explicit config return hardcoded disabled defaults (all flags false)
• Messenger Requirements: Clients must configure RemoteFeatureFlagController:getState, ErrorReportingService:captureException as allowed actions, and RemoteFeatureFlagController:stateChange as allowed event
• The getFeatureFlags constructor option is deprecated and ignored.

Links to draft migration PRs:

• Extension: feat(STX-331): replace legacy STX swaps flags with smart transaction flags from remote config API metamask-extension#38572
• Mobile: WIP

---

Note

Migrates smart-transaction feature flags to RemoteFeatureFlagController with per-chain validation, selectors, and Sentry error reporting; deprecates getFeatureFlags.

• BREAKING:
  • Controller now reads flags via RemoteFeatureFlagController:getState and listens to RemoteFeatureFlagController:stateChange; getFeatureFlags option deprecated/ignored.
  • Requires messenger allowlist updates for actions RemoteFeatureFlagController:getState, ErrorReportingService:captureException and event RemoteFeatureFlagController:stateChange.
• Controller (src/SmartTransactionsController.ts):
  • Integrates remote flags; validates on state changes and reports errors via ErrorReportingService:captureException.
  • Uses chain-specific flags when marking regular txs failed and for return-tx-hash-asap behavior.
• Feature flags module:
  • Adds src/featureFlags/* with validators (superstruct), processing, normalizeChainId, and chain-level merging; introduces DEFAULT_DISABLED_SMART_TRANSACTIONS_FEATURE_FLAGS fallback.
• Selectors/Exports:
  • Adds src/selectors.ts with selectSmartTransactionsFeatureFlags and selectSmartTransactionsFeatureFlagsForChain; exports from src/index.ts.
• Utils (src/utils.ts):
  • Switches helpers to accept SmartTransactionsNetworkConfig instead of legacy flags.
• Tests: Extensive new tests for controller validation, feature-flag processing, selectors, and utils updates.
• Docs (README.md, CHANGELOG.md):
  • Documents remote flag usage, schema extension, defaults, and migration notes.
• Dependencies (package.json):
  • Adds @metamask/superstruct, @metamask/utils, reselect; dev/peer deps for @metamask/remote-feature-flag-controller and @metamask/error-reporting-service.

^{Written by Cursor Bugbot for commit 27e2f33. This will update automatically on new commits. Configure here.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​metamask/​remote-feature-flag-controller@​2.0.1
	@​metamask/​error-reporting-service@​3.0.0

View full report