fix: review

packages/snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snap-solana-wallet.git"
   },
   "source": {
-    "shasum": "aqOdyICdZWwwirkDtw8MwwMHNiqT/nJblgJCwYCyppw=",
+    "shasum": "k8Iw/hr3sRgRGK4eaVRyFUBwcXUL75cbze8Er3BlaSk=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

packages/snap/src/core/handlers/onCronjob/backgroundEvents/refreshConfirmationEstimation.tsx

@@ -18,7 +18,6 @@ export const refreshConfirmationEstimation: OnCronjobHandler = async () => {
     '[refreshConfirmationEstimation]',
   );
 
-  //   try {
   logger.info(
     `[${ScheduleBackgroundEventMethod.RefreshConfirmationEstimation}] Background event triggered`,
   );
@@ -143,10 +142,4 @@ export const refreshConfirmationEstimation: OnCronjobHandler = async () => {
       `[${ScheduleBackgroundEventMethod.RefreshConfirmationEstimation}] Could not update the interface. But rolled back status to fetched.`,
     );
   }
-  //   } catch (error) {
-  //     logger.warn(
-  //       { error },
-  //       `[${ScheduleBackgroundEventMethod.RefreshConfirmationEstimation}] Background event failed`,
-  //     );
-  //   }
 };

packages/snap/src/core/handlers/onCronjob/backgroundEvents/refreshSend.tsx

@@ -17,88 +17,87 @@ import { ScheduleBackgroundEventMethod } from './ScheduleBackgroundEventMethod';
 export const refreshSend: OnCronjobHandler = async () => {
   const logger = createPrefixedLogger(baseLogger, '[refreshSend]');
 
-  try {
+  //   try {
+  logger.info(
+    `[${ScheduleBackgroundEventMethod.RefreshSend}] Background event triggered`,
+  );
+
+  const [assets, mapInterfaceNameToId, preferences] = await Promise.all([
+    assetsService.getAll(),
+    state.getKey<UnencryptedStateValue['mapInterfaceNameToId']>(
+      'mapInterfaceNameToId',
+    ),
+    getPreferences().catch(() => DEFAULT_SEND_CONTEXT.preferences),
+  ]);
+
+  const assetTypes = assets.flatMap((asset) => asset.assetType);
+
+  const sendFormInterfaceId = mapInterfaceNameToId?.[SEND_FORM_INTERFACE_NAME];
+
+  // Don't do anything if the send form interface is not open
+  if (!sendFormInterfaceId) {
     logger.info(
-      `[${ScheduleBackgroundEventMethod.RefreshSend}] Background event triggered`,
+      `[${ScheduleBackgroundEventMethod.RefreshSend}] ❌ No send form interface found`,
     );
+    return;
+  }
 
-    const [assets, mapInterfaceNameToId, preferences] = await Promise.all([
-      assetsService.getAll(),
-      state.getKey<UnencryptedStateValue['mapInterfaceNameToId']>(
-        'mapInterfaceNameToId',
-      ),
-      getPreferences().catch(() => DEFAULT_SEND_CONTEXT.preferences),
-    ]);
-
-    const assetTypes = assets.flatMap((asset) => asset.assetType);
-
-    const sendFormInterfaceId =
-      mapInterfaceNameToId?.[SEND_FORM_INTERFACE_NAME];
-
-    // Don't do anything if the send form interface is not open
-    if (!sendFormInterfaceId) {
-      logger.info(
-        `[${ScheduleBackgroundEventMethod.RefreshSend}] ❌ No send form interface found`,
-      );
-      return;
-    }
-
-    // Schedule the next run
-    await snap.request({
-      method: 'snap_scheduleBackgroundEvent',
-      params: { duration: 'PT30S', request: { method: 'refreshSend' } },
-    });
-
-    // First, fetch the token prices
-    const tokenPrices = await priceApiClient.getMultipleSpotPrices(
-      assetTypes,
-      preferences.currency,
-    );
+  // Schedule the next run
+  await snap.request({
+    method: 'snap_scheduleBackgroundEvent',
+    params: { duration: 'PT30S', request: { method: 'refreshSend' } },
+  });
 
-    // Save them in the state
-    await state.setKey('tokenPrices', tokenPrices);
-
-    // Get the current context
-    const interfaceContext =
-      await getInterfaceContextOrThrow<SendContext>(sendFormInterfaceId);
-
-    // We only want to refresh the token prices when the user is in the transaction confirmation stage
-    if (interfaceContext.stage !== 'transaction-confirmation') {
-      logger.info(
-        `[${ScheduleBackgroundEventMethod.RefreshSend}] ❌ Not in transaction confirmation stage`,
-      );
-      return;
-    }
-
-    if (!interfaceContext.assets) {
-      logger.info(
-        `[${ScheduleBackgroundEventMethod.RefreshSend}] ❌ No assets found`,
-      );
-      return;
-    }
-
-    // Update the current context with the new rates
-    const updatedInterfaceContext = {
-      ...interfaceContext,
-      tokenPrices: {
-        ...interfaceContext.tokenPrices,
-        ...tokenPrices,
-      },
-    };
-
-    await updateInterface(
-      sendFormInterfaceId,
-      <Send context={updatedInterfaceContext} />,
-      updatedInterfaceContext,
-    );
+  // First, fetch the token prices
+  const tokenPrices = await priceApiClient.getMultipleSpotPrices(
+    assetTypes,
+    preferences.currency,
+  );
 
+  // Save them in the state
+  await state.setKey('tokenPrices', tokenPrices);
+
+  // Get the current context
+  const interfaceContext =
+    await getInterfaceContextOrThrow<SendContext>(sendFormInterfaceId);
+
+  // We only want to refresh the token prices when the user is in the transaction confirmation stage
+  if (interfaceContext.stage !== 'transaction-confirmation') {
     logger.info(
-      `[${ScheduleBackgroundEventMethod.RefreshSend}] ✅ Background event suceeded`,
+      `[${ScheduleBackgroundEventMethod.RefreshSend}] ❌ Not in transaction confirmation stage`,
     );
-  } catch (error) {
-    logger.warn(
-      { error },
-      `[${ScheduleBackgroundEventMethod.RefreshSend}] ❌ Background event failed`,
+    return;
+  }
+
+  if (!interfaceContext.assets) {
+    logger.info(
+      `[${ScheduleBackgroundEventMethod.RefreshSend}] ❌ No assets found`,
     );
+    return;
   }
+
+  // Update the current context with the new rates
+  const updatedInterfaceContext = {
+    ...interfaceContext,
+    tokenPrices: {
+      ...interfaceContext.tokenPrices,
+      ...tokenPrices,
+    },
+  };
+
+  await updateInterface(
+    sendFormInterfaceId,
+    <Send context={updatedInterfaceContext} />,
+    updatedInterfaceContext,
+  );
+
+  logger.info(
+    `[${ScheduleBackgroundEventMethod.RefreshSend}] ✅ Background event suceeded`,
+  );
+  //   } catch (error) {
+  //     logger.warn(
+  //       { error },
+  //       `[${ScheduleBackgroundEventMethod.RefreshSend}] ❌ Background event failed`,
+  //     );
+  //   }
 };