-
Notifications
You must be signed in to change notification settings - Fork 637
Replace tsup with ts-bridge
#2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
892da5d to
f7abe82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 481 481
Lines 10056 10056
Branches 1521 1521
=======================================
Hits 9484 9484
Misses 572 572 ☔ View full report in Codecov by Sentry. |
f67d427 to
450144a
Compare
|
@metamaskbot update-pr |
d9faa9c to
891def6
Compare
|
@metamaskbot update-pr |
|
@metamaskbot update-pr |
| "module": "ES2020", | ||
| "moduleResolution": "Node10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snaps-sdk has a .ts file which declares *.svg, *.png, etc., but this doesn't work in Node16 or NodeNext module resolution. I've kept snaps-sdk and the image example at Node10 for now, to not introduce any breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this file because there was a folder called types and also a file types.ts, so importing from ./types could refer to either, and caused issues in ts-bridge.
| "module": "ES2020", | ||
| "moduleResolution": "Node10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snaps-sdk has a .ts file which declares *.svg, *.png, etc., but this doesn't work in Node16 or NodeNext module resolution. I've kept snaps-sdk and the image example at Node10 for now, to not introduce any breaking changes.
This replaces
tsupwithts-bridge, which fixes several issues we've found intsup.Related to MetaMask/metamask-module-template#247, MetaMask/utils#182.