Skip to content

Making LookupClient disposable and improved TCP client pool #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaCo wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Making LookupClient disposable and improved TCP client pool #220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6037e37
Making MessageHandler disposable.
MichaCo Mar 17, 2024
714f1d7
disposable updates
MichaCo Mar 20, 2024
8679a3d
unit test update
MichaCo Jun 30, 2024
8e36b6f
moving some new tests over
MichaCo Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unit test update
  • Loading branch information
@MichaCo
MichaCo committed Jun 30, 2024
commit 8679a3dac7c6dead9ce0f8dd944c88f3d86c873c
4 changes: 2 additions & 2 deletions test-other/OldReference/TestLookupClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public LookupClient SetNonDefaults()

public void TestQuery_1_1()
{
var client = new LookupClient();
var client = new LookupClient(NameServer.GooglePublicDns.Address);
client.Query("domain", QueryType.A);
client.Query("domain", QueryType.A, QueryClass.IN);
client.QueryReverse(IPAddress.Loopback);
Expand All @@ -71,7 +71,7 @@ public void TestQuery_1_1()

public async Task TestQueryAsync_1_1()
{
var client = new LookupClient();
var client = new LookupClient(NameServer.GooglePublicDns.Address);
await client.QueryAsync("domain", QueryType.A).ConfigureAwait(false);
await client.QueryAsync("domain", QueryType.A, QueryClass.IN).ConfigureAwait(false);
await client.QueryAsync("domain", QueryType.A, cancellationToken: default).ConfigureAwait(false);
Expand Down
3 changes: 2 additions & 1 deletion test/DnsClient.Tests/LookupTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@ public async Task Lookup_Query_SettingsCannotBeNull()
[Fact]
public async Task Lookup_GetHostAddresses_Local()
{
using var client = new LookupClient();
var servers = NameServer.ResolveNameServers(true, false);
using var client = new LookupClient(servers.ToArray());

var result = await client.QueryAsync("localhost", QueryType.A);

Expand Down