Skip to content

Warn and let PCIe devices w/o ACS to go through #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imbushuo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warn and let PCIe devices w/o ACS to go through #1419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Warn and let PCIe devices w/o ACS to go through 
As suggested in https://docs.microsoft.com/en-us/virtualization/community/team-blog/2015/20151120-discrete-device-assignment-machines-and-devices, the ACS requirement of PCIe devices can be overridden with `-Force` switch with risks of system security (VM isolation) and stability. Warn the user about possible consequences, but let the script to go through in such scenario.
  • Loading branch information
@imbushuo
imbushuo authored Jun 8, 2020
commit beadc67079f30b341364d714b7cd79a1a3404ee6
6 changes: 4 additions & 2 deletions hyperv-tools/DiscreteDeviceAssignment/SurveyDDA.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ foreach ($pcidev in $pcidevs) {

$acsUp = ($pcidev | Get-PnpDeviceProperty $devpkey_PciDevice_AcsCompatibleUpHierarchy).Data
if ($acsUp -eq $devprop_PciDevice_AcsCompatibleUpHierarchy_NotSupported) {
write-host -ForegroundColor Red -BackgroundColor Black "Traffic from this device may be redirected to other devices in the system. Not assignable."
continue
write-host -ForegroundColor Yellow -BackgroundColor Black "Warning: Traffic from this device may be redirected to other devices in the system."
write-host -ForegroundColor Yellow -BackgroundColor Black "It is strongly recommend to assign devices with proper ACS support for system security and reliability."
write-host -ForegroundColor Yellow -BackgroundColor Black "While it is possible to assign it to VM with -Force switch when running Dismount-VMHostAssignableDevice,"
write-host -ForegroundColor Yellow -BackgroundColor Black "PCIe security will not be enforced so all workloads should be trusted."
}

$devtype = ($pcidev | Get-PnpDeviceProperty $devpkey_PciDevice_DeviceType).Data
Expand Down