State JS code snippets point to unhelpful lines #2141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Create conversation and user state objects" JS snippet is pointing to a section of code that no longer makes sense. It currently is unhelpful in explaining how to set up state. Update points to https://github.com/microsoft/BotBuilder-Samples/blob/28a039d99221ec6819f08659467363e9bb5913b9/samples/javascript_nodejs/45.state-management/index.js#L49-L56, but I'm not certain whether all of them should be included or not.
Contributor
|
Unfortunately, there is currently a lot of churn in the samples repo. The devs will let us know when they are done, and we'll do a bulk refresh of the docs at that time. Hopefully, their work will wrap up very soon. Feel free to open this as an issue, and we'll close it when we update the docs. Sorry for the confusion. |
Contributor
|
@eoinobrien -- I pushed a bunch of code snippet alignment fixes earlier this week, including a fix for this article. |
Contributor
|
PS. There are still open samples PRs outstanding, so there's a little churn left. :| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Create conversation and user state objects" JS snippet is pointing to a section of code that no longer makes sense. It currently is unhelpful in explaining how to set up state.
Update points to index.js#L49-L56, but I'm not certain whether all of the lines should be included or not.