expand validationFunction #4
Conversation
Hello everyone! After working through this chapter of the documentation I propose to expand the code-snippet of the validation function for the SandwichOrder's FormBuilder. In the style of the other examples, there should be more surrounding code to make it easier for inexperienced readers to understand where the validation function should be added to. During my first read-through, I had to pull up and search the corresponding sample project to understand where this code should live, which was different than other parts of the documentation previously.
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
Hi @mHulb! Thanks for your contribution. The author of this snippet will review your PR. Thanks! |
kbrandl
left a comment
kbrandl
left a comment
There was a problem hiding this comment.
Thank you for contributing this documentation update! I've added comments to the PR to request a few minor changes; if you can please update your snippet accordingly we'll merge those changes in to the live docs. Thanks again!
| ... | ||
| return new FormBuilder<SandwichOrder>() | ||
| .Message("Welcome to the sandwich order bot!") | ||
| ... |
There was a problem hiding this comment.
Please remove the "..." here and instead add these four lines that precede the Toppings line in the sample app:
.Field(nameof(Sandwich))
.Field(nameof(Length))
.Field(nameof(Bread))
.Field(nameof(Cheese))
| select topping).ToList(); | ||
| } | ||
| return result; | ||
| }) |
There was a problem hiding this comment.
Please indent "})" further so that its indentation matches the opening brace "{" for the validate function.
| } | ||
| return result; | ||
| }) | ||
| .Message("For sandwich toppings you have selected {Toppings}.") |
There was a problem hiding this comment.
After the line .Message("For sandwich toppings you have selected {Toppings}."), please add these 3 lines:
...
.Build();
}
Four your reference (re proper indentation), here's what all four of those lines should look like together:
.Message("For sandwich toppings you have selected {Toppings}.")
...
.Build();
}
| return result; | ||
| }) | ||
| .Message("For sandwich toppings you have selected {Toppings}.") | ||
| .Message("For sandwich toppings you have selected {Toppings}.") |
There was a problem hiding this comment.
Finally, please remove the duplicate line .Message("For sandwich toppings you have selected {Toppings}.") from the end of the snippet.
Hello @kbrandl! Thank you for the opportunity to contribute to the documentation. I've applied the requested changes to the snippet.
4 participants
Hello everyone!
After working through this chapter of the documentation I propose to expand the code-snippet of the validation function for the SandwichOrder's FormBuilder.
In the style of the other examples, there should be more surrounding code to make it easier for inexperienced readers to understand where the validation function should be added to. During my first read-through, I had to pull up and search the corresponding sample project to understand where this code should live, which was different from other parts of the documentation previously.