Patch 7 #118
Merged
Patch 7 #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified what information can be used in a Tabs URL, returned by the microsoftTeams.getContext() object, and clarified the wording for theme change handling.
* Updated Context and theme information Clarified what information can be used in a Tabs URL, returned by the microsoftTeams.getContext() object, and clarified the wording for theme change handling. * Icon spec change (MicrosoftDocs#85) * Updated icon sizes (MicrosoftDocs#87)
…d) (MicrosoftDocs#95) There are only 2 overloads on the extension method: SendToConversationAsync(this IConversations operations, Activity activity, CancellationToken cancellationToken = default(CancellationToken)); SendToConversationAsync(this IConversations operations, string conversationId, Activity activity, CancellationToken cancellationToken = default(CancellationToken));
…hod (MicrosoftDocs#94) * Added sample code extract to demonstrate AsTeamsChannelAccounts() method Making it clearer how to implement functionality * Minor edits * Updated JSON formatting
* Norm control library (MicrosoftDocs#101) * Add control library topic * toc * link * trdt * Added second part * proofreading * edits * links * Edits (MicrosoftDocs#98) * added links to React and Redux * changed heading capitalization style to match rest of docs * fixed commas, spaces, capitalization bugs, monospace formatting * Made changes for PR MicrosoftDocs#100 * Norm authentication rework (MicrosoftDocs#103) * Added structure for new authentication content * Added content to top level * Rough draft of tab authentication topic with new screenshots * Fixed format issue * Formatting test * Formatting * Added content for SSO * Structural edits * list test * test * test * test * Test * test * test * test * test * indent code * test * tst * test * Updated bot auth * Added new samples for bot auth * Corrected code for auth * Expanded code for bot auth * Minor edits * Removed work in progress * More term changes and rewrite * More review comments * Review comments * TOC * Added support for other providers * Removed app registration * minor edits * Pre publication changes * Extensive edits, added links, native image * Added missing space * Made title match metadata * Misc changes (MicrosoftDocs#97) * Misc changes 1. Missing comma 2. Fixed 404 dead link to SDK 3. Misc editing 4. Attempted to clarify murky mobile auth story 5. Fixed sample code labels * Added Visio sequence diagram source Bot and tab auth sequence diagrams * Added folder for authentication images * Delete placeholder.md * Added copy of PNG instead of linking to asolis repo * Extensive edits, updated bitmap, added links * Updated flow diagram * toc changes * fixed link * Extensive edits (MicrosoftDocs#99) Technical accuracy, additional links, reordered last two sections, minor edits. * Restructured auth topics * added links to auth provider * TOC * Changes from readthrough * edits * edits * edits * formatting * edits * standardize * Billbl auth final edits (MicrosoftDocs#102) * Minor edits and clarifications * Enlarged to fit available space * Enlarged to fit available space * replaced by lowercase filename version * Mistakenly posted to wrong directory * Minor edits * Tech review and clarification Fixed some of my own bugs and clarified the distinction between state validation and <verification code> validation. * Fixed grammar bug * Grammar change to bot auth diagram * Technical review changes * Extensive revisions to reflect bot auth sample Previous version referenced Josh's sample; Adrian's is quite different. * Added clarification - no bot support * Changed to "identity provider" nomenclature * Changed to "identity provider" nomenclature * Minor edits and nomenclature change * authentication -> identity * Fixed broken links
* Updated for new auth and Teams graph info As per https://domoreexp.visualstudio.com/MSTeams/_workitems/edit/234506?source=compose * update resource files per Vivian Hsu
There used to be just one authentication.md file under concepts, now there's an authentication root at authentication/authentication.md. Will leave this branch to be merged with master too. There will be a small merge conflict but since this is a non-destructive change (if the redirect doesn't work the 404 error still occurs) it's easy to fix.
* Refactoring of auth content There used to be just one authentication.md file under concepts, now there's an authentication root at authentication/authentication.md. * Create master redirection file Added entry for relocated authentication content. * Deleted (didn't work) * Added .md extension to source_path
* Refactoring of auth content There used to be just one authentication.md file under concepts, now there's an authentication root at authentication/authentication.md. * Create master redirection file Added entry for relocated authentication content. * Deleted (didn't work) * Added .md extension to source_path * Added leading slash to redirect_url
* Updated for new auth and Teams graph info As per https://domoreexp.visualstudio.com/MSTeams/_workitems/edit/234506?source=compose * update resource files per Vivian Hsu * Norm delete messages (MicrosoftDocs#109) * support for bots deleting messages * edits * added links * date * TypeScript
|
|
Contributor
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| msteams-platform/concepts/bots/bots-context.md | Details | ||
| msteams-platform/concepts/cards-actions.md | Details | ||
| msteams-platform/publishing/office-store-guidance.md | Details | ||
| msteams-platform/scenarios/bots-personal-conversations.md | Details | ||
| .openpublishing.redirection.json | ✅Succeeded | ||
| msteams-platform/redirects/authentication.md | ✅Succeeded |
msteams-platform/concepts/bots/bots-context.md
- Line 25: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#bot-or-user-added-to-a-team).
- Line 130: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#bot-or-user-added-to-a-team).
msteams-platform/concepts/cards-actions.md
- Line 12: [Warning] Invalid file link:(~/concepts/cards-actions#hero-card).
- Line 13: [Warning] Invalid file link:(~/concepts/cards-actions#thumbnail-card).
- Line 61: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
- Line 76: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
- Line 85: [Warning] Invalid file link:(~/concepts/connectors#using-office-365-connector-cards-in-microsoft-teams).
- Line 95: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
msteams-platform/publishing/office-store-guidance.md
- Line 9: [Warning] Invalid file link:(~/publishing/apps-publish).
- Line 73: [Warning] Invalid file link:(~/publishing/apps-publish#microsoft-teams-app-approval-process).
msteams-platform/scenarios/bots-personal-conversations.md
- Line 9: [Warning] Invalid file link:(~/scenarios/bots-channel-conversations).
- Line 21: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#team-member-or-bot-addition).
- Line 21: [Warning] Invalid file link:(~/scenarios/bots-channel-conversations).
- Line 21: [Warning] Invalid file link:(~/concepts/bots/bots-context#fetching-the-team-roster).
- Line 115: [Warning] Invalid file link:(~/resources/design/overview).
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.
NormSohl
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manifest version correction