-
Notifications
You must be signed in to change notification settings - Fork 533
[Dev-Docs AI Improvement]: Create a tab #13643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Acrolinx ScorecardsWe currently enforce a minimum score of 80. Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:
More info about Acrolinx Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 14dfd06: ✅ Validation status: passed
For more details, please refer to the build report. |
| > [!IMPORTANT] | ||
| > | ||
| > We've introduced [Microsoft 365 Agents Toolkit](../../toolkit/agents-toolkit-fundamentals.md) (previously known as Teams Toolkit) extension within Visual Studio Code. This version comes to you with many new app development features. We recommend that you use Agents Toolkit v5 for building your Teams app. | ||
| > Microsoft has introduced [Microsoft 365 Agents Toolkit](../../toolkit/agents-toolkit-fundamentals.md) (previously known as Teams Toolkit) extension within Visual Studio Code. This release includes many new app development features. Use Agents Toolkit v5 for building your Teams app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Microsoft has introduced...
MSTP: When the tone is friendly, informative, or inspiring, use 'we' and 'our'.
| > [!IMPORTANT] | ||
| > | ||
| > We've introduced [Microsoft 365 Agents Toolkit](../../toolkit/agents-toolkit-fundamentals.md) (previously known as Teams Toolkit) extension within Visual Studio Code. This version comes to you with many new app development features. We recommend that you use Agents Toolkit v5 for building your Teams app. | ||
| > Microsoft has introduced [Microsoft 365 Agents Toolkit](../../toolkit/agents-toolkit-fundamentals.md) (previously known as Teams Toolkit) extension within Visual Studio Code. This release includes many new app development features. Use Agents Toolkit v5 for building your Teams app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Agents Toolkit...
This is a recommendation, not a CTA.
| > We've introduced [Microsoft 365 Agents Toolkit](../../toolkit/agents-toolkit-fundamentals.md) (previously known as Teams Toolkit) extension within Visual Studio Code. This version comes to you with many new app development features. We recommend that you use Agents Toolkit v5 for building your Teams app. | ||
| > Microsoft has introduced [Microsoft 365 Agents Toolkit](../../toolkit/agents-toolkit-fundamentals.md) (previously known as Teams Toolkit) extension within Visual Studio Code. This release includes many new app development features. Use Agents Toolkit v5 for building your Teams app. | ||
| Ensure that you've all the [prerequisites](~/tabs/how-to/tab-requirements.md) to build your tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure vs Confirm
'Ensure' is preferred over 'Confirm '.
| ``` | ||
| 1. Provide your values to a series of questions prompted by Microsoft Teams app generator to update your `manifest.json` file. | ||
| 1. Provide your values when prompted by Microsoft Teams app generator to update your `manifest.json` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...to a series of questions ... vs. when
This is edit is not required. It doesn't add value and also takes away that the Dev must respond to a series of questions in subsequent steps. The step is given to prepare them for what's coming next.
| * **What is your solution name?** | ||
| The solution name is your project name. You can accept the suggested name by selecting **Enter**. | ||
| Your project name acts as your solution name. Accept the suggested name by selecting **Enter**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Dev has the option to change the suggested name. We can't make it a command.
| * View details of previously submitted requests, incidents, or forms. | ||
| When the user's device reconnects to the internet, the tab automatically synchronizes the locally stored data with an Azure Blob storage. This action ensures that all offline changes made by the user are updated in a central storage, maintaining data consistency across the organization. | ||
| When the device reconnects, the tab automatically synchronizes locally stored data with Azure Blob storage to ensure consistency across the organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed information - all offline changes made by the user are updated in a central storage,
| 1. Clone the [Microsoft Teams Samples](https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/) repository. | ||
| 1. In the cloned repository, go to **samples** > **tab-support-offline** > **nodejs** and open the folder in Visual Studio Code. | ||
| 1. In the cloned repository, navigate to **samples** > **tab-support-offline** > **nodejs** and open the folder in Visual Studio Code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go to vs. navigate
| 1. Sign in with your Microsoft 365 account, if prompted. | ||
| 1. Select **Add** when a dialog box opens to let you add the tab app to Teams. | ||
| 1. In **EXPLORER**, open **server** > **blobStoreOperations.js** and replace `{{ account-Name }}` and `{{ container-Name }}` with your Azure Blob storage account and container values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments as earlier
- Use 'go to' vs 'open' in this context
- Select vs Press
- Comma is required before 'if prompted'
| :::image type="content" source="../../assets/images/tabs/add-offline-tab-teams.png" alt-text="Screenshot shows how to add the offline tab app to Teams."::: | ||
| Congratulations! You've successfully created a Teams tab with offline functionality. | ||
| Congratulations! You have successfully built a Teams tab with offline functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standard: Use contractions
| ## Best practices for tabs in Teams mobile | ||
| To learn how to optimize your tab's performance in the Teams Android and iOS clients, see [best practices for Teams mobile](../../resources/teams-mobile-best-practices.md). | ||
| For guidance on optimizing tab performance in Teams Android and iOS clients, see [best practices for Teams mobile](../../resources/teams-mobile-best-practices.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant edit.
v-shalinirob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR review done.
This PR updates the content of the file: msteams-platform/tabs/how-to/create-personal-tab.md.
Submitted by: @yashy797