-
Notifications
You must be signed in to change notification settings - Fork 533
[Dev-Docs AI Improvement]: Nested app authentication #13648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Acrolinx ScorecardsWe currently enforce a minimum score of 80. Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:
More info about Acrolinx Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 1a3583d: 💡 Validation status: suggestions
msteams-platform/concepts/authentication/nested-authentication.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
NehaHEDAU-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 17: NAA introduces is not correct. It should be NAA is.. Also Heading should not have short form (NAA) instead, can add it in the first line itself as Nested app authentication (NAA) is ..
NehaHEDAU-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 39: The meaning is changed.
NehaHEDAU-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 45, the original usage of the is correct..the Contoso app
NehaHEDAU-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 269: Microsoft Style Guide suggests using active voice but the changed version uses passive voice.. please change
| ### Register your SPA | ||
|
|
||
| You must create a Microsoft Entra ID app registration for your add-in on Azure portal. The app registration must have a name, supported account type, and SPA redirect. Following the registration of your app, Azure portal generates a Microsoft Entra app registration ID. | ||
| Create a Microsoft Entra ID app registration for your add-in on Azure portal. The app registration requires a name, supported account type, and SPA redirect. Upon registering your app, Azure portal generates a Microsoft Entra app registration ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line app registration requires a name is incorrect.. The usage of must is correct as must indicates it's mandatory.
| Initialize MSAL and get an instance of the public client app to get access tokens, when needed. | ||
| Initialize MSAL and obtain an instance of the public client app to retrieve access tokens when needed. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSTP suggests using simple words..so obtain is not right.
This PR updates the content of the file: msteams-platform/concepts/authentication/nested-authentication.md.
Submitted by: @yashy797