Skip to content

Fix issues #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Fix issues #1797

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19c512c
Add ignore file support
Fogolan Oct 2, 2018
c7d9e83
Fix encoding and absolute md path
Fogolan Oct 2, 2018
98a21dd
doc obj support
Fogolan Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add ignore file support
  • Loading branch information
@Fogolan
Fogolan committed Oct 2, 2018
commit 19c512ca05e857b3b9de62dfa7da28a2a9a9efdd
3 changes: 2 additions & 1 deletion tools/office-cmdlet-updater/config/default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"platyPS": {
"docPath": "..\\..\\teams\\teams-ps\\teams"
"docPath": "..\\..\\teams\\teams-ps\\teams",
"ignoreFiles": []
},
"sendgrid": {
"sendMailNotification": false,
Expand Down
13 changes: 11 additions & 2 deletions tools/office-cmdlet-updater/services/markdown.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,18 @@ class MarkdownService {

async addMdFilesInQueue(folderPath) {
const mdExt = '.md';
const { ignoreFiles } = this.config.get('platyPS');
const ignoreAbsolutePathsArr = ignoreFiles.map((f) => path.resolve(f));

const allFiles = await fs.readdir(folderPath);
const mdFiles = allFiles.filter((fileName) => fileName.endsWith(mdExt));
const isFileIgnore = (fileName) => {
const absoluteFilePath = path.resolve(fileName);

return ignoreAbsolutePathsArr.includes(absoluteFilePath);
};

const mdFiles = (await fs.readdir(folderPath))
.map((f) => path.resolve(folderPath, f))
.filter((fn) => fn.endsWith(mdExt) && !isFileIgnore(fn));

mdFiles.forEach((fileName) => {
const absolutePath = path.resolve(`${folderPath}\\${fileName}`);
Expand Down