feat: native prover build #18012
feat: native prover build #18012
Conversation
bleepbloopsify
force-pushed
the
leon/native-prover-build
branch
from
9b18de9 to
cef9291
Compare
bleepbloopsify
force-pushed
the
leon/native-prover-build
branch
from
cef9291 to
1769fde
Compare
…neration-functions feat: proof generation functions (native prover)
|
|
||
| rm -f "${CURRENT_DIRECTORY}/plonk_napi.node" | ||
| cp "${ARTIFACT}" "${CURRENT_DIRECTORY}/plonk_napi.node" | ||
| napi build \ |
| // This file gets auto-included in the generated plonk-napi types to supplement | ||
| // external pointer types. | ||
|
|
||
| type WasmPastaFpPlonkIndex = {}; |
There was a problem hiding this comment.
This means every time we have any External<T> we need to include a type T = {} here? Just confirming, looks like what you shared with us during this week call.
There was a problem hiding this comment.
Yes we will probably have to declare the external types on our own
this is a weird quirk of the napi typegen, it doesn't spit out the names of the external types
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "napi": { | |||
| "binaryName": "plonk_napi", | |||
There was a problem hiding this comment.
Actually, this is a TODO: we wanted to rename plonk-wasm into kimchi-wasm, and the same for plonk-napi to kimchi-napi. But let's do that once we have it working to avoid a renaming craziness.
| try { | ||
| var native = require('@o1js/native-' + process.platform + '-' + process.arch) | ||
|
|
||
| function override(functionName) { |
There was a problem hiding this comment.
Don't we prefer a helper here to avoid repeating this pattern over and over again as we have more overrides?
There was a problem hiding this comment.
we could do something like
const new = {
...wasm,
...napi,
};There was a problem hiding this comment.
I fixed this in the follow-up
| var plonk_wasm = (function() { | ||
| var wasm = require('./plonk_wasm.js'); | ||
|
|
||
| function snakeToCamel(name) { |
There was a problem hiding this comment.
Makes sense to delete this already given that napi does this automatically (unlike neon did).
| var plonk_wasm = globalThis.plonk_wasm; | ||
|
|
||
| // Provides: plonk_napi | ||
| var plonk_napi = globalThis.plonk_wasm |
There was a problem hiding this comment.
oh sure, in web we still will have wasm
| // This file gets auto-included in the generated plonk-napi types to supplement | ||
| // external pointer types. | ||
|
|
||
| type WasmPastaFpPlonkIndex = {}; |
| try { | ||
| var native = require('@o1js/native-' + process.platform + '-' + process.arch) | ||
|
|
||
| function override(functionName) { |
There was a problem hiding this comment.
we could do something like
const new = {
...wasm,
...napi,
};
|
prefer the above PR to this one |
reset to native/napi
adds build and package.json dependency injection for native assets