Skip to content

Expand per-file diffs inline in changed files panel#594

Merged
Mng-dev-ai merged 1 commit into
mainfrom
expand-changed-files-diffs
May 3, 2026
Merged

Expand per-file diffs inline in changed files panel#594
Mng-dev-ai merged 1 commit into
mainfrom
expand-changed-files-diffs

Conversation

@Mng-dev-ai
Copy link
Copy Markdown
Owner

Summary

  • Adds a per-file expand toggle in the changed-files panel that fetches and renders the diff inline using the existing tool DiffView
  • Adds an "open in diff view" affordance that focuses the corresponding file in the full DiffView pane, opening the pane on mobile or appending it to the desktop mosaic
  • Backend exposes GET /chat/messages/{id}/changes/diff?path=... returning a per-path diff against the message's checkpoint base (with the pre-run patch applied)
  • Refactors GitService to share patch-file write and tree-build logic between changed-files and per-file-diff queries; excludes the temporary .agentrove-changed-*.patch from results

Test plan

  • Expand a changed file row in a chat message and confirm the diff renders
  • Click the diff-view shortcut and confirm the DiffView pane opens (mobile + desktop mosaic) and scrolls to the file
  • Restore a checkpoint and re-open the panel; verify deleted files show no editor link but still expand to a diff

Adds an inline diff toggle on each changed file row and a shortcut to
open the file in the full diff view, so users can review checkpoint
changes without leaving the chat thread.
@Mng-dev-ai Mng-dev-ai merged commit 5fe4e95 into main May 3, 2026
4 checks passed
pull Bot pushed a commit to woakes070048/claudex that referenced this pull request May 9, 2026
Fill in the harness content layer that PR 1 routed to. Each artifact
doc captures the rules an agent must know before writing that artifact
type; each domain map gives entry points, vocabulary, gotchas, and
verified prior-art PRs.

Backend artifacts (docs/artifacts/backend/):
- models.md      — SQLAlchemy 2.x async, Mapped[], custom column types,
                   Alembic workflow, anti-patterns
- endpoints.md   — FastAPI route handlers, deps.py wiring, domain
                   exceptions, auth dependencies, SSE/WS conventions
- services.md    — class-based service shape, BaseDbService, exception
                   discipline, integration boundaries
- tests.md       — endpoint-tests-only, conftest fixtures, fake providers,
                   stub-vs-real boundaries
- integrations.md — Docker, GitHub, ACP, SMTP, Redis ownership matrix

Frontend artifacts (docs/artifacts/frontend/):
- components.md     — React 19 patterns, primitives, contexts/providers,
                      hooks discipline, anti-patterns
- state.md          — Zustand vs context vs useState decision tree
- data-fetching.md  — TanStack Query setup, query-key factory, prefix
                      keys for cwd-scoped invalidation, mutation patterns
- styling.md        — Tailwind tokens, monochrome palette, primitives,
                      typography/icon/animation rules

Domain maps (docs/domains/):
- chat.md       — entities, message state machine, queue/send-now,
                  cross-domain edges; PRs Mng-dev-ai#592, Mng-dev-ai#593, Mng-dev-ai#594, Mng-dev-ai#560, Mng-dev-ai#419, Mng-dev-ai#251, Mng-dev-ai#454
- sandbox.md    — Docker vs Host providers, lifecycle; PRs Mng-dev-ai#590, Mng-dev-ai#588,
                  Mng-dev-ai#531, Mng-dev-ai#505, Mng-dev-ai#551, Mng-dev-ai#594
- providers.md  — ACP adapter registry, per-agent quirks, persona
                  gating; PRs Mng-dev-ai#591, Mng-dev-ai#589, Mng-dev-ai#528, Mng-dev-ai#499, Mng-dev-ai#542, Mng-dev-ai#538, Mng-dev-ai#541, Mng-dev-ai#465, Mng-dev-ai#537
- streaming.md  — StreamEnvelope, seq-based reconnection, snapshot vs
                  control events; PRs Mng-dev-ai#370, #173, #190, Mng-dev-ai#382, Mng-dev-ai#432, Mng-dev-ai#346, Mng-dev-ai#214, Mng-dev-ai#524, Mng-dev-ai#471, #192
- auth.md       — fastapi-users, refresh tokens, encrypted-at-rest,
                  WS auth handshake; PRs Mng-dev-ai#586, Mng-dev-ai#587, Mng-dev-ai#589, Mng-dev-ai#449, Mng-dev-ai#550, Mng-dev-ai#469
- git.md        — GitService surface, worktrees, ChatCheckpoint;
                  PRs Mng-dev-ai#592, Mng-dev-ai#594, Mng-dev-ai#593, Mng-dev-ai#596, Mng-dev-ai#527, Mng-dev-ai#398, Mng-dev-ai#402
- workspace.md  — workspaces, skills, personas, slash commands;
                  PRs Mng-dev-ai#598, Mng-dev-ai#597, Mng-dev-ai#596, Mng-dev-ai#506, Mng-dev-ai#510, Mng-dev-ai#537, Mng-dev-ai#542, Mng-dev-ai#561, Mng-dev-ai#414, Mng-dev-ai#464, Mng-dev-ai#476, Mng-dev-ai#563

Each prior-art PR was verified via gh pr view (state=MERGED, files
within the cited domain) before citation.

Cleanup:
- AGENTS.md: removed PR-1's "Doc status" footer; routing tables now
  point at real files. The github.md route was rolled into git.md and
  workspace.md (no separate domain map needed at current surface area).
- docs/legacy.md deleted — content now lives in the per-artifact docs
  it sourced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant