Gh result elements #123
Merged
Gh result elements #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add abstract type AbstractResultElement. - Generate list of result element objects during MBS initialization stored in scene. - Call basic result element functions: * initializeResultElement(model, result) once before simulation. * evaluateResultElement(model, scene, result, time) in every communication point evaluation. * terminateResultElement(result) once after simulation.
- Add result element for MPR contact results. - Function `getElasticContactPair` based on implementation of [email protected]. - Add comments and documentation.
- Add test model BouncingSphereContactResults.jl.
- Improve comments in elasticCollisionResponse.jl. - Improve plot definitions in BouncingSphereContactResults.jl.
Comment on lines
+75
to
+76
| (contactPair, converse) = getElasticContactPair(scene, result.object1, result.object2) | ||
| if !isnothing(contactPair) |
There was a problem hiding this comment.
Did you check with code_warntype if the type of contactPair can be evaluated during runtime? If not, the types of contactPair.results. ... must be defined.
There was a problem hiding this comment.
Thanks, should be okay now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.