Skip to content

[alpha_factory] Fix lint hooks and Insight preview asset checks#4623

Open
MontrealAI wants to merge 2 commits intomainfrom
codex/fix-all-errors-3rpg2a
Open

[alpha_factory] Fix lint hooks and Insight preview asset checks#4623
MontrealAI wants to merge 2 commits intomainfrom
codex/fix-all-errors-3rpg2a

Conversation

@MontrealAI
Copy link
Copy Markdown
Owner

Motivation

  • Fix failing repository hooks and gallery validation so CI linting and demo preview checks pass.
  • Ensure the Insight browser lint step can run by installing the required Node.js version and dependencies.

Description

  • Normalize formatting in alpha_factory_v1/demos/alpha_agi_insight_v1/insight_browser_v1/manual_build.py to satisfy the formatter hooks.
  • Update tests/test_ci_ruff_scope_contract.py to use consistent quoting and formatting expected by black.
  • Add the missing mirrored preview asset at docs/alpha_agi_insight_v1/assets/preview.svg to satisfy gallery validation.
  • Accept the workflow action pin update in .github/workflows/ci.yml for the sticky PR comment action.

Testing

  • Ran pre-commit run --all-files after fixes and all hooks passed (including black, ruff, flake8, semgrep, and eslint for the Insight browser).
  • Installed Node.js 22.17.1 with nvm install 22.17.1 and ran npm ci in alpha_factory_v1/demos/alpha_agi_insight_v1/insight_browser_v1 so the ESLint hook could run successfully.
  • Executed pytest tests/test_ping_agent.py tests/test_af_requests.py --cov --cov-report=xml which produced 2 passed, 1 skipped and wrote coverage.xml successfully.

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant