[alpha_factory] Fix lint hooks and Insight preview asset checks#4623
Open
MontrealAI wants to merge 2 commits intomainfrom
Open
[alpha_factory] Fix lint hooks and Insight preview asset checks#4623MontrealAI wants to merge 2 commits intomainfrom
MontrealAI wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
alpha_factory_v1/demos/alpha_agi_insight_v1/insight_browser_v1/manual_build.pyto satisfy the formatter hooks.tests/test_ci_ruff_scope_contract.pyto use consistent quoting and formatting expected byblack.docs/alpha_agi_insight_v1/assets/preview.svgto satisfy gallery validation..github/workflows/ci.ymlfor the sticky PR comment action.Testing
pre-commit run --all-filesafter fixes and all hooks passed (includingblack,ruff,flake8,semgrep, andeslintfor the Insight browser).22.17.1withnvm install 22.17.1and rannpm ciinalpha_factory_v1/demos/alpha_agi_insight_v1/insight_browser_v1so the ESLint hook could run successfully.pytest tests/test_ping_agent.py tests/test_af_requests.py --cov --cov-report=xmlwhich produced2 passed, 1 skippedand wrotecoverage.xmlsuccessfully.Codex Task