Skip to content

MudDataGrid: Add default and customizable ARIA semantics to select column #12911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielchalmers merged 18 commits into from
Apr 10, 2026
Merged

MudDataGrid: Add default and customizable ARIA semantics to select column #12911

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bbd1a58
Initial plan
Codex Feb 10, 2026
f3be919
Add ARIA semantics to DataGrid selection
Codex Feb 10, 2026
8544e7a
Fix DataGrid aria-selected rendering for non-selectable rows
versile2 Mar 27, 2026
0a569e0
Fix SelectColumn ARIA label precedence for custom labelledby
versile2 Mar 27, 2026
e4c1834
Refactor DataGrid ARIA tests to re-query DOM after rerenders
versile2 Mar 27, 2026
766c592
fix(datagrid): omit aria-selected for disabled rows
versile2 Mar 27, 2026
461940d
refactor(datagrid): keep aria defaults scoped to selection
versile2 Mar 27, 2026
d8a6c27
refactor(datagrid): use row content for checkbox labels
versile2 Mar 27, 2026
aeb4021
refactor(datagrid): simplify row checkbox aria labels
versile2 Mar 30, 2026
4228ac9
refactor(datagrid): tighten default row aria labels
versile2 Apr 6, 2026
0ce9bb1
doc update
versile2 Apr 6, 2026
8d8c083
fix(datagrid): restore default aria label fallback
versile2 Apr 7, 2026
00b71c1
perf(datagrid): skip row aria label work without select column
versile2 Apr 7, 2026
899ef2e
revert back to file-scoped namespace
danielchalmers Apr 8, 2026
e48c593
Simplify implementation
danielchalmers Apr 8, 2026
8008ba5
Update MudDataGrid.razor
danielchalmers Apr 10, 2026
2867309
Update DataGridVirtualizeRow.razor
danielchalmers Apr 10, 2026
0bc090d
Merge branch 'dev' into codex/add-default-aria-labels
danielchalmers Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor DataGrid ARIA tests to re-query DOM after rerenders
  • Loading branch information
@versile2
versile2 committed Mar 27, 2026
commit e4c1834e70469709b0fe413282af918d72bf0d52
10 changes: 5 additions & 5 deletions src/MudBlazor.UnitTests/Components/DataGridTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5294,23 +5294,23 @@ public async Task SelectColumn_SetsAriaSelectedOnRows()
}));

List<IElement> Rows() => comp.FindAll("tbody tr").ToList();
List<IElement> RowCheckboxes() => comp.FindAll("tbody .mud-checkbox input").ToList();
IElement HeaderCheckbox() => comp.Find("thead .mud-checkbox input");

Rows()[0].GetAttribute("aria-selected").Should().Be("false");
Rows()[1].GetAttribute("aria-selected").Should().Be("false");

var rowCheckboxes = comp.FindAll("tbody .mud-checkbox input");
await rowCheckboxes[0].ChangeAsync(true);
await RowCheckboxes()[0].ChangeAsync(true);

Rows()[0].GetAttribute("aria-selected").Should().Be("true");
Rows()[1].GetAttribute("aria-selected").Should().Be("false");

var headerCheckbox = comp.Find("thead .mud-checkbox input");
await headerCheckbox.ChangeAsync(true);
await HeaderCheckbox().ChangeAsync(true);

Rows()[0].GetAttribute("aria-selected").Should().Be("true");
Rows()[1].GetAttribute("aria-selected").Should().Be("true");

await headerCheckbox.ChangeAsync(false);
await HeaderCheckbox().ChangeAsync(false);

Rows()[0].GetAttribute("aria-selected").Should().Be("false");
Rows()[1].GetAttribute("aria-selected").Should().Be("false");
Expand Down
Loading