chore: Upgrade slevomat/coding-standard to fully support PHP 8.1
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the rules from the Doctrine CS directly to our own ruleset, removing the dependency on the Doctrine CS. This allowed me to upgrade the Slevomat rules, otherwise we'll have to wait for an update of the Doctrine CS.
frankverhoeven
requested review from
littlestfluffy,
fred-jan,
gertjuhh,
jkiesebrink and
Peter-Weijenburg
fred-jan
reviewed
Jul 12, 2022
|
It is if we want to use PHP 8.1 features. We could also wait though, work has been done on the Doctrine side, but of course I don't know when a release is due. We could also include doctrine CS |
|
Closing in favour of #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied the rules from the Doctrine CS directly to our own ruleset, removing the
dependency on the Doctrine CS. This allowed me to upgrade the Slevomat rules,
otherwise we'll have to wait for an update of the Doctrine CS.
Dropped support for PHP 7.4, because we no longer use it.