Upgrade with Doctrine coding-standard as base #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense, the overview at https://www.doctrine-project.org/projects/doctrine-coding-standard/en/latest/reference/index.html#introduction mentions points that are common sense. If I look at your PR for configuration it becomes clear it has benefits in picking out subtle mistakes. |
digibeuk
approved these changes
May 18, 2020
fred-jan
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the coding standard to use the Doctrine coding-standard as basis. The Symfony coding standard will be dropped. Reason being the way more active development of the Doctrine CS and feature-set it has to offer.
This upgrade does not alter previous rules, but does introduce loads of new rules. Best source of information on this is the Doctrine repository: https://github.com/doctrine/coding-standard.
Upgrading in configuration, that previously passed all rules, looked as follows: https://github.com/MyOnlineStore/configuration/pull/166