Skip to content

Conversation

@markpet49
Copy link
Member

Description of the Change

Update the source code to conform to usual Java formatting practices, particularly in regard to curly brace placement.

@markpet49 markpet49 requested a review from Beak-man September 11, 2019 22:40
@Beak-man Beak-man merged commit 53e51a2 into develop Sep 11, 2019
@Beak-man Beak-man deleted the source-formatting branch September 11, 2019 22:46
@wcmatthysen
Copy link

wcmatthysen commented Sep 11, 2019

@markpet49, reformatting an entire code-base like you just did pretty much screws up any forks / downstream repositories that have made any significant code-changes. Now the said forks have to deal with a shitload of merge-conflicts if they ever want to keep up to date with the upstream repository here. That is not something I would have done so lightly and merged in so quickly.

@markpet49
Copy link
Member Author

@wcmatthysen Good point, we'll back it out in a bit and take a more measured approach.

@Beak-man
Copy link
Member

This change was reverted in #180

quonn77 pushed a commit to quonn77/WorldWindJava that referenced this pull request May 8, 2023
…ting

Update the code formatting to be more conformant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants