fixing a small but confusing typo in parameter file description of fates_mort_disturb_frac#1394
Merged
Conversation
jennykowalcz
added
the
type: clean up
glemieux
approved these changes
May 15, 2025
glemieux
moved this from Finding Reviewers
to Final Testing
in FATES Pull Request Planning and Status
glemieux
moved this from Final Testing
to Hold
in FATES Pull Request Planning and Status
github-project-automation
Bot
moved this from Hold
to Ready to Integrate
in FATES Pull Request Planning and Status
samsrabin
added a commit
to samsrabin/fates
that referenced
this pull request
Jun 10, 2025
updates to the default parameter file This update includes a phenology parameter refactor per NGEET#1355, an update to the default exclusion parameter per NGEET#1358, updates to the logging parameters to default to clearcut via NGEET#1359, and a minor long name correction per NGEET#1394.
samsrabin
added a commit
to samsrabin/fates
that referenced
this pull request
Jun 23, 2025
updates to the default parameter file This update includes a phenology parameter refactor per NGEET#1355, an update to the default exclusion parameter per NGEET#1358, updates to the logging parameters to default to clearcut via NGEET#1359, and a minor long name correction per NGEET#1394.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Change description of fates_mort_disturb_frac in the parameter file from "fraction of canopy mortality that results in disturbance (i.e. transfer of area from new to old patch)" to "fraction of canopy mortality that results in disturbance (i.e. transfer of area from old to new patch)"
Collaborators:
Expectation of Answer Changes:
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: