Skip to content

Conversation

@Kahath
Copy link
Contributor

@Kahath Kahath commented Jun 7, 2019

Currently there are only 4 options for target line ending mode, CRLF|LF|CR|None.
This pull request adds null terminator line ending mode to target "lineEnding" attribute in configuration.
https://github.com/NLog/NLog/wiki/Network-target

@welcome
Copy link

welcome bot commented Jun 7, 2019

Thanks for opening this pull request!
We will try to review this soon! Please note that pull requests with unit tests are earlier accepted 👼

@codecov-io
Copy link

codecov-io commented Jun 7, 2019

Codecov Report

Merging #3453 into master will increase coverage by <1%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master   #3453    +/-   ##
=======================================
+ Coverage      80%     80%   +<1%     
=======================================
  Files         359     359            
  Lines       28634   28636     +2     
  Branches     3817    3818     +1     
=======================================
+ Hits        22916   22919     +3     
  Misses       4620    4620            
+ Partials     1098    1097     -1

@304NotModified
Copy link
Member

THanks for the PR!

What's the exact use case for this line ending?

@Kahath
Copy link
Contributor Author

Kahath commented Jun 7, 2019

Graylog GELF over TCP has option for null terminator line ending mode. It's called null frame delimiter.

@304NotModified 304NotModified changed the base branch from dev to master June 8, 2019 11:39
@304NotModified
Copy link
Member

thanks! I changed to commit to master, so I could include it in NLog 4.6.5 :)

@304NotModified 304NotModified added this to the 4.6.5 milestone Jun 8, 2019
@Kahath
Copy link
Contributor Author

Kahath commented Jun 9, 2019

Nice. Thanks :)

@304NotModified 304NotModified changed the base branch from master to release/4.6.5 June 9, 2019 07:58
@304NotModified 304NotModified merged commit be264eb into NLog:release/4.6.5 Jun 9, 2019
@welcome
Copy link

welcome bot commented Jun 9, 2019

Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks!
thanks!

@304NotModified
Copy link
Member

NLog 4.6.5 has been released! https://www.nuget.org/packages/NLog/4.6.5 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants