Skip to content

Conversation

@snakefoot
Copy link
Contributor

Looks like the real-ip will have a default-gateway:

https://stackoverflow.com/questions/8089685/c-sharp-finding-my-machines-local-ip-address-and-not-the-vms

While the VMware Network Adapter will have none or just 0.0.0.0

@snakefoot snakefoot added this to the 4.7 milestone Jan 7, 2020
@snakefoot snakefoot added the enhancement Improvement on existing feature label Jan 7, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

89.7% 89.7% Coverage
0.0% 0.0% Duplication

@snakefoot
Copy link
Contributor Author

@jol5 Please check if the pre-release-build is able to resolved the expected ${local-ip}:

https://ci.appveyor.com/project/nlog/nlog/builds/29958203/artifacts

@304NotModified
Copy link
Member

Polite bump @jol5

@snakefoot
Copy link
Contributor Author

snakefoot commented Jan 16, 2020

@304NotModified Don't think jol5 have English as first language and not in the mood for playing with local nuget-package stores, so it will be an uphill challenge to get any confirmation.

You just have to take my word (or rather stackoverflows word) for that the solution will be working for VM-Ware-Nodes.

@304NotModified 304NotModified merged commit b9bc12a into NLog:master Jan 16, 2020
@304NotModified
Copy link
Member

Ok merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement on existing feature size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants