Skip to content

AsyncTargetWrapper - Do not schedule lazy writer timer, when other active writer #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
304NotModified merged 1 commit into from
Feb 4, 2020
Merged

AsyncTargetWrapper - Do not schedule lazy writer timer, when other active writer #3790

304NotModified merged 1 commit into from
Feb 4, 2020

Conversation

@snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 3, 2020 •
edited
Loading

Trying to resolve #3789. Hard to write an unit-test as it is hard to reproduce (Not even sure it is the issue).

@snakefoot snakefoot added this to the 4.7 milestone Feb 3, 2020
@snakefoot snakefoot added the enhancement Improvement on existing feature label Feb 3, 2020
@304NotModified
Copy link
Member

304NotModified commented Feb 3, 2020

Could we reproduce it locally?

304NotModified
304NotModified reviewed Feb 3, 2020
View reviewed changes
@snakefoot
Copy link
Contributor Author

snakefoot commented Feb 4, 2020 •
edited
Loading

Could we reproduce it locally?

Not anywhere near the thread-amount that the issue showed. It is probably similar to #3412

@snakefoot snakefoot force-pushed the AsyncTargetWrapperThrottleTimer branch from d9ad202 to 3b39716 Compare February 4, 2020 06:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@304NotModified
Copy link
Member

304NotModified commented Feb 4, 2020

OK, I think we should merge it as it won't hurt any way? Or do you like to wait for a confirmation?

@snakefoot
Copy link
Contributor Author

snakefoot commented Feb 4, 2020

I think it should just be merged. Since all evidence was lost (would really have liked to see the internal logger output) and apparently not easy to re-produce.

@304NotModified 304NotModified merged commit 11a5765 into NLog:master Feb 4, 2020
@304NotModified
Copy link
Member

304NotModified commented Feb 4, 2020

merged 👍 thanks!

@304NotModified 304NotModified mentioned this pull request Feb 5, 2020
Closed
@snakefoot snakefoot deleted the AsyncTargetWrapperThrottleTimer branch April 4, 2020 12:47
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Open
@dependabot dependabot bot mentioned this pull request Sep 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@304NotModified 304NotModified 304NotModified left review comments

Assignees

No one assigned

Labels

enhancement Improvement on existing feature size/M

Projects

None yet

Milestone

4.7

Development

Successfully merging this pull request may close these issues.

2 participants

@snakefoot @304NotModified