Skip to content

Conversation

@snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 14, 2020

Reusing the logic from DbConnection to also apply properties for DbCommand:

<target name="db"
        xsi:type="Database"
        commandType="StoredProcedure"
        commandText="[dbo].[NLog_AddEntry_p]"
        >
  <commandProperty name="CommandTimeout" layout="${gdc:DefaultCommandTimeout}" propertyType="System.Int32" />
  <parameter name="@logged"         layout="${date}" />
  <parameter name="@level"          layout="${level}" />
  <parameter name="@message"        layout="${message}" />
  <parameter name="@logger"         layout="${logger}" />
</target>

See also #3829

@snakefoot snakefoot force-pushed the DbConnectionProperties branch 2 times, most recently from fff67d6 to 197059c Compare March 14, 2020 22:11
@snakefoot snakefoot added this to the 4.7 milestone Mar 14, 2020
@snakefoot snakefoot force-pushed the DbConnectionProperties branch from 197059c to 61a268e Compare March 15, 2020 08:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

95.8% 95.8% Coverage
0.0% 0.0% Duplication

@304NotModified
Copy link
Member

very nice, thanks!

@304NotModified 304NotModified merged commit 21d8239 into NLog:master Mar 15, 2020
@304NotModified
Copy link
Member

@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database-target documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) feature size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants