Skip to content

JsonSerializer - Ensure invariant formatting of DateTimeOffset #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
304NotModified merged 1 commit into from
Oct 30, 2020
Merged

JsonSerializer - Ensure invariant formatting of DateTimeOffset #4142

304NotModified merged 1 commit into from
Oct 30, 2020

Conversation

@snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 22, 2020 •
edited
Loading

Really strange but VS2019 16.8 Preview then this:

QuoteValue(destination, $"{value:yyyy-MM-dd HH:mm:ss zzz}");`

Fails in formatting:

   Expected: "2016-12-31 02:30:59 +04:30"
    Actual:   "2016-12-31 02.30.59 +04:30"

By forcing CultureInfo.InvariantCulture then it works as expected.

@snakefoot snakefoot added bug Bug report / Bug fix json / json-layout labels Oct 22, 2020
@snakefoot snakefoot added this to the 4.7.6 milestone Oct 22, 2020
@snakefoot snakefoot force-pushed the JsonDateTimeOffsetInvariant branch from cd70e7c to e159c30 Compare October 25, 2020 21:29
@snakefoot snakefoot changed the base branch from dev to master October 26, 2020 00:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@304NotModified 304NotModified merged commit 19de9e7 into NLog:master Oct 30, 2020
@304NotModified
Copy link
Member

304NotModified commented Oct 30, 2020

nice!

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
@snakefoot snakefoot deleted the JsonDateTimeOffsetInvariant branch July 30, 2022 10:31
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Open
This was referenced Sep 2, 2025
Open
Closed
@dependabot dependabot bot mentioned this pull request Oct 1, 2025
Open
@dependabot dependabot bot mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Bug report / Bug fix json / json-layout size/M

Projects

None yet

Milestone

4.7.6

Development

Successfully merging this pull request may close these issues.

2 participants

@snakefoot @304NotModified