Skip to content

[model] feat: Add limited Gemma4 dense model support#3885

Open
pavelgein wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
pavelgein:gemma4_31b
Open

[model] feat: Add limited Gemma4 dense model support#3885
pavelgein wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
pavelgein:gemma4_31b

Conversation

@pavelgein
Copy link
Copy Markdown
Contributor

What does this PR do ?

Current implementation of Gemma4VL Bridge supports only MoE models.
This restrictions is loosed to support Gemma4 31B model, since it does not have a per-layer embeddings

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Signed-off-by: Pavel Gein <pavel.gein@gmail.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 19, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyu-33 yaoyu-33 added area:model Model implementations and HF bridge logic feature New capabilities, enhancements, or enablement work waiting-on-maintainers Waiting on maintainers to respond labels May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:model Model implementations and HF bridge logic community-request feature New capabilities, enhancements, or enablement work waiting-on-maintainers Waiting on maintainers to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants