Skip to content

Fix logprobs issues. #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcampora merged 1 commit into from
Jun 12, 2025
Merged

Fix logprobs issues. #5136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tensorrt_llm/_torch/pyexecutor/sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,8 +721,8 @@ def update_requests(self, state: SampleStateTRTLLM):
if request.py_return_log_probs:
# NOTE: Log probs with drafting has not been tested yet.
begin_log_probs_offset = request.prompt_len if request.sampling_config.beam_width == 1 else 0
current_token = seq_len - request.prompt_len - len(
num_new_tokens[beam]) + step
current_token = seq_len - request.prompt_len - num_new_tokens[
beam] + step

log_probs.append({
new_token.item():
Expand All @@ -732,7 +732,7 @@ def update_requests(self, state: SampleStateTRTLLM):
rank=1)
})

if num_new_tokens[beam] > 0 and request.py_return_log_probs:
if request.py_return_log_probs:
cum_log_probs.append(
state.host.cum_log_probs[seq_slot * beam_width +
beam].item())
Expand Down