fix:remove duplicated trust_remote_code knob from trtllm-serve #5143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-guomingz
commented
Jun 12, 2025
nv-guomingz
force-pushed
the
user/guomingz/clean_duplilcate_serve_option
branch
from
8b6cb0b to
f72d6f6
Compare
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #8589 [ run ] triggered by Bot |
Collaborator
|
Hi @nv-guomingz, I already created PR here. |
yechank-nvidia
approved these changes
Jun 12, 2025
Collaborator
Author
No worries, let's use #5072 for removing this duplicate knob. |
Collaborator
|
PR_Github #8589 [ run ] completed with state |
Signed-off-by: nv-guomingz <[email protected]>
nv-guomingz
force-pushed
the
user/guomingz/clean_duplilcate_serve_option
branch
from
f72d6f6 to
3708031
Compare
Collaborator
Author
|
/bot reuse-pipeline |
Collaborator
|
PR_Github #8673 [ reuse-pipeline ] triggered by Bot |
Collaborator
|
PR_Github #8673 [ reuse-pipeline ] completed with state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the duplicated
trust_remote_codeknob which raised by #4799