-
Notifications
You must be signed in to change notification settings - Fork 2k
[chore] Disable block reuse when draft model speculation is being used #5448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0db19e5 to
7ec4aa0
Compare
|
/bot run |
|
PR_Github #9753 [ run ] triggered by Bot |
|
PR_Github #9753 [ run ] completed with state |
7ec4aa0 to
dbac0db
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #9889 [ run ] triggered by Bot |
|
PR_Github #9889 [ run ] completed with state |
Signed-off-by: Mike Iovine <[email protected]>
dbac0db to
fdb22a0
Compare
|
/bot reuse-pipeline |
|
PR_Github #9909 [ reuse-pipeline ] triggered by Bot |
|
/bot reuse-pipeline |
|
PR_Github #9910 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #9909 [ reuse-pipeline ] completed with state |
|
PR_Github #9910 [ reuse-pipeline ] completed with state |
NVIDIA#5448) Signed-off-by: Mike Iovine <[email protected]>
NVIDIA#5448) Signed-off-by: Mike Iovine <[email protected]>
NVIDIA#5448) Signed-off-by: Mike Iovine <[email protected]>
NVIDIA#5448) Signed-off-by: Mike Iovine <[email protected]>
NVIDIA#5448) Signed-off-by: Mike Iovine <[email protected]>
NVIDIA#5448) Signed-off-by: Mike Iovine <[email protected]>
NVIDIA#5448) Signed-off-by: Mike Iovine <[email protected]>
NVIDIA#5448) Signed-off-by: Mike Iovine <[email protected]>
Description
The issue is as follows:
context_current_position > 0if there are cached blocks: https://github.com/NVIDIA/TensorRT-LLM/blob/main/tensorrt_llm/_torch/pyexecutor/resource_manager.py#L310. It actually mutates the LLM requestis_first_context_chunkreturnsFalseand no pages are allocated.The root of this issue is the mutation. I think we should refactor this such that the LLM request is more agnostic to its KV cache manager.
context_current_position.get_num_cached_tokensposition_id = req.context_current_position + kv_cache_manager.get_num_cached_tokens(req).I'm not sure how feasible the above refactor is. For now, I've just disabled KV cache reuse and logged a warning when a drafter is required. This is consistent with what we do when the attention backend doesn't support block reuse.
Test Coverage
Existing tests.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.