Skip to content

Conversation

@Superjomn
Copy link
Collaborator

@Superjomn Superjomn commented Jul 10, 2025

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • New Features

    • Added a tokens_per_block option in KV cache settings (default: 64) to control tokens per block; value is applied at runtime when provided.
  • Refactor

    • Streamlined executor configuration: tokens_per_block is no longer exposed via executor configuration and is now managed through KV cache settings.

@Superjomn Superjomn requested a review from QiJune July 10, 2025 09:17
@Superjomn Superjomn changed the title api: expose tokens_per_block into KvCacheConfig chore: expose tokens_per_block into KvCacheConfig Jul 10, 2025
@Superjomn Superjomn force-pushed the add-tokens-per-block branch from 70c6157 to 398edfc Compare July 10, 2025 09:19
@Superjomn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11538 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11538 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8541 completed with status: 'FAILURE'

Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn requested a review from lucaslie July 11, 2025 02:08
@Superjomn Superjomn force-pushed the add-tokens-per-block branch from 398edfc to 6abb3e8 Compare July 11, 2025 05:24
@Superjomn Superjomn requested a review from a team as a code owner July 11, 2025 05:24
@Superjomn Superjomn requested a review from yuxianq July 11, 2025 05:24
@Superjomn Superjomn force-pushed the add-tokens-per-block branch from 6abb3e8 to c0b8a26 Compare July 11, 2025 05:27
@Superjomn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11605 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11605 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8599 completed with status: 'FAILURE'

@Superjomn Superjomn force-pushed the add-tokens-per-block branch 2 times, most recently from 13208c1 to 14bb591 Compare July 12, 2025 15:10
@Superjomn Superjomn requested a review from a team as a code owner July 12, 2025 15:10
@Superjomn Superjomn requested a review from juney-nvidia July 12, 2025 15:10
@Superjomn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11710 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11710 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8666 completed with status: 'FAILURE'

@Superjomn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11760 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11760 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8711 completed with status: 'FAILURE'

@Superjomn Superjomn force-pushed the add-tokens-per-block branch from 1012f27 to f4c5993 Compare July 14, 2025 07:42
@Superjomn
Copy link
Collaborator Author

/bot run

@Superjomn
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17760 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17760 [ run ] completed with state DISABLED
L0 testing is limited to prioritized users. User Superjomn is not in the prioritized list. L0 testing cannot be triggered.

@richardhuo-nv
Copy link
Collaborator

/bot run --disable-fail-fast

1 similar comment
@pcastonguay
Copy link
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17788 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17788 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13318 completed with status: 'FAILURE'

@Superjomn Superjomn force-pushed the add-tokens-per-block branch 2 times, most recently from 0d17677 to 1ab900d Compare September 5, 2025 23:34
@Superjomn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17830 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17830 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13347 completed with status: 'FAILURE'

@pcastonguay
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17890 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17890 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13399 completed with status: 'FAILURE'

Signed-off-by: Superjomn <[email protected]>
@pcastonguay
Copy link
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17893 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17893 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13402 completed with status: 'FAILURE'

@pcastonguay
Copy link
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17932 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17932 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13439 completed with status: 'FAILURE'

@pcastonguay
Copy link
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17951 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17951 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13454 completed with status: 'SUCCESS'

@pcastonguay pcastonguay merged commit 205c3a1 into NVIDIA:main Sep 8, 2025
5 checks passed
@Superjomn Superjomn deleted the add-tokens-per-block branch September 8, 2025 01:21
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants