[fix] Update jenkins container images #6094
Conversation
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #12072 [ run ] triggered by Bot |
ixlmar
force-pushed
the
fix/update-jenkins-container
branch
from
b07dba2 to
df95327
Compare
|
/bot run --skip-test |
|
PR_Github #12087 [ run ] triggered by Bot |
|
PR_Github #12072 [ run ] completed with state |
|
PR_Github #12087 [ run ] completed with state |
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #12178 [ run ] triggered by Bot |
Signed-off-by: ixlmar <[email protected]>
|
PR_Github #12178 [ run ] completed with state |
ixlmar
force-pushed
the
fix/update-jenkins-container
branch
from
df95327 to
2d83798
Compare
WalkthroughThe Makefile for Docker Jenkins builds was updated to dynamically select the appropriate Rocky Linux 8 image based on the Python version specified. Documentation was revised to reflect this logic and to provide detailed instructions for building and pushing CI images. The image tags in the properties file were updated with new identifiers and clarifying comments. Changes
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
jenkins/current_image_tags.properties (1)
11-13: Clarifying comment successfully addresses earlier feedback
The new note explicitly explains why an abbreviated commit hash may appear in the suffix, closing the documentation gap highlighted in the previous review.
🧹 Nitpick comments (2)
jenkins/current_image_tags.properties (1)
14-17: Consider centralising the common tag suffix to avoid copy-paste drift
All four image variables repeat the same lengthy-202507162011-ec3ebaesuffix. Even though the file deliberately keeps redundant substrings for script-compatibility (see lines 8-10), extracting just the final suffix into its own variable (e.g.TAG_SUFFIX=?) would still retain full strings after interpolation while eliminating the risk of one tag diverging from the others.docker/README.md (1)
134-165: Minor tweaks to CI-image build instructions
docker buildx create --name multi-buildercreates but does not select the builder; either append--useor add a separatedocker buildx use multi-builderstep to prevent “no builder instance” errors on first use.- It can be helpful to bootstrap the new builder once:
docker buildx inspect multi-builder --bootstrap.- The initial command
make -C docker jenkins_buildassumes an implicit_buildsuffix; consider showing the fully expanded target (jenkins_build) in the Makefile snippet for clarity.These small clarifications will save new contributors a round-trip of troubleshooting.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docker/Makefile(1 hunks)docker/README.md(2 hunks)jenkins/current_image_tags.properties(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
docker/Makefile (1)
183-185: Shell-variable indirection looks correct
Usingecho $$LLM_ROCKYLINUX8_${PYTHON_VERSION_TAG_ID}_DOCKER_IMAGEcorrectly double-escapes the first$for make while allowing${…}substitution before the shell runs. Nice attention to detail.docker/README.md (1)
92-94: Good alignment with new image-tag source of truth
Updating the Jenkins section to referencecurrent_image_tags.propertiesreflects the recent refactor and avoids stale documentation.
|
/bot skip --comment "/bot run --stage-list Build-Docker-Images succeeded" |
|
PR_Github #12203 [ skip ] triggered by Bot |
|
PR_Github #12204 Bot args parsing error: Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): |
|
PR_Github #12203 [ skip ] completed with state |
Signed-off-by: ixlmar <[email protected]>
4 participants
[fix] Update jenkins container images
Description
This is a follow-up to #5964
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit
Documentation
Chores