Skip to content

Conversation

@byshiue
Copy link
Collaborator

@byshiue byshiue commented Jul 17, 2025

Summary by CodeRabbit

  • Documentation
    • Updated the support matrix to include Qwen3ForCausalLM and Qwen3MoeForCausalLM models, along with their HuggingFace examples and modality tags.
    • Expanded reference links for Qwen models in the TensorRT backend section to include Qwen3.

@byshiue byshiue requested a review from a team as a code owner July 17, 2025 22:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2025

Walkthrough

The documentation was updated to add support for two new Qwen3-based models, specifying their HuggingFace examples and modality tags. The reference link for Qwen models in the TensorRT backend section was also expanded to include Qwen3.

Changes

File(s) Change Summary
docs/source/reference/support-matrix.md Added Qwen3ForCausalLM and Qwen3MoeForCausalLM to supported models; updated Qwen reference link

Poem

In the docs, new Qwen3s appear,
With models and links now crystal clear.
The matrix grows, the list extends,
As TensorRT-LLM welcomes new friends.
Hopping ahead, we document with glee—
More models for all, from Qwen to Qwen3!
🐰📚✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@byshiue
Copy link
Collaborator Author

byshiue commented Jul 17, 2025

/bot skip --comment "only update doc"

@byshiue byshiue added the Doc <NV>TRTLLM's textual/illustrative materials: API refs, guides, tutorials. Improvement & clarity. label Jul 17, 2025
@byshiue
Copy link
Collaborator Author

byshiue commented Jul 18, 2025

/bot skip --comment "only update doc"

@byshiue byshiue enabled auto-merge (squash) July 18, 2025 03:09
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/source/reference/support-matrix.md (1)

28-29: Align MoE naming and double-check the HF example slug

Qwen3MoeForCausalLM vs. Qwen3MoE mixes the “e/E” capitalisation. Pick one convention (the repo usually uses MoE) for both the architecture column and the friendly model name to avoid search / copy-paste friction.
While touching the row, please confirm the HF repo is the exact slug (Qwen/Qwen3-30B-A3B looks uncommon; many repos use …-A32B or …-MixMoE).

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eeca3ad and de4b224.

📒 Files selected for processing (1)
  • docs/source/reference/support-matrix.md (2 hunks)
🔇 Additional comments (1)
docs/source/reference/support-matrix.md (1)

77-77: LGTM – link update accurately reflects Qwen3 addition
No issues found with the modified bullet.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12267 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12267 [ skip ] completed with state SUCCESS
Skipping testing for commit de4b224

@byshiue byshiue merged commit 9323de6 into NVIDIA:release/0.21 Jul 18, 2025
3 checks passed
dc3671 pushed a commit to dc3671/TensorRT-LLM that referenced this pull request Jul 21, 2025
dc3671 pushed a commit to dc3671/TensorRT-LLM that referenced this pull request Jul 21, 2025
dc3671 pushed a commit to dc3671/TensorRT-LLM that referenced this pull request Jul 21, 2025
dc3671 pushed a commit to dc3671/TensorRT-LLM that referenced this pull request Jul 22, 2025
dc3671 pushed a commit that referenced this pull request Jul 22, 2025
NVShreyas pushed a commit to NVShreyas/TensorRT-LLM that referenced this pull request Jul 28, 2025
Ransiki pushed a commit to Ransiki/TensorRT-LLM that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Doc <NV>TRTLLM's textual/illustrative materials: API refs, guides, tutorials. Improvement & clarity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants