[https://nvbugs/5419069][fix] Fix the mismatched layer name components. #6417

hyukn · 2025-07-28T15:46:04Z

Summary by CodeRabbit

Bug Fixes
- Improved handling of model key names for certain internal dictionaries to ensure consistency.
Tests
- Removed a test from the skip list, allowing it to run as part of the standard test suite.

coderabbitai · 2025-07-28T15:46:11Z

📝 Walkthrough

Walkthrough

The update modifies the smooth_qwen2_model function to rename dictionary keys by removing the 'language_model.' prefix in three specific dictionaries after smoothing computations. Additionally, a test waiver entry related to a specific Qwen smooth quantization test has been removed from the integration test skip list.

Changes

Cohort / File(s)	Change Summary
Qwen Model Key Renaming `tensorrt_llm/models/qwen/convert.py`	Adds logic to remove the `'language_model.'` prefix from keys in `scales`, `qwen_qkv_para`, and `qwen_smoother` dictionaries after smoothing.
Test Waiver Removal `tests/integration/test_lists/waives.txt`	Removes a waiver entry for a specific Qwen smooth quantization test from the skip list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested reviewers

venkywonka
yiqingy0

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7f5d42 and a84cac7.

📒 Files selected for processing (2)

tensorrt_llm/models/qwen/convert.py (1 hunks)
tests/integration/test_lists/waives.txt (0 hunks)

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

🚧 Files skipped from review as they are similar to previous changes (1)

tensorrt_llm/models/qwen/convert.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hyukn · 2025-07-28T15:46:24Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-28T15:51:34Z

PR_Github #13214 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-28T15:52:19Z

PR_Github #13214 [ run ] completed with state FAILURE

hyukn · 2025-07-28T23:58:58Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-29T00:03:59Z

PR_Github #13249 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-29T00:37:05Z

PR_Github #13249 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #9893 completed with status: 'FAILURE'

hyukn · 2025-07-29T06:19:11Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-29T06:24:33Z

PR_Github #13309 [ run ] triggered by Bot

hyukn · 2025-07-30T00:51:56Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-30T00:52:07Z

PR_Github #13309 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9943 completed with status: 'SUCCESS'

tensorrt-cicd · 2025-07-30T00:58:43Z

PR_Github #13444 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T01:24:11Z

PR_Github #13444 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10061 completed with status: 'SUCCESS'

hyukn · 2025-07-30T09:06:28Z

/bot --help

github-actions · 2025-07-30T09:06:36Z

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

hyukn · 2025-07-30T09:07:54Z

/bot run --disable-fail-fast --post-merge

tensorrt-cicd · 2025-07-30T09:12:55Z

PR_Github #13518 [ run ] triggered by Bot

hyukn · 2025-07-30T13:22:28Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-30T13:28:07Z

PR_Github #13543 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T13:28:09Z

PR_Github #13518 [ run ] completed with state ABORTED

tensorrt-cicd · 2025-07-30T16:44:38Z

PR_Github #13543 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10151 completed with status: 'FAILURE'

hyukn · 2025-07-31T01:33:24Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-31T01:43:19Z

PR_Github #13587 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-31T03:05:41Z

PR_Github #13587 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10187 completed with status: 'FAILURE'

hyukn · 2025-07-31T03:14:03Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-31T03:19:05Z

PR_Github #13597 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-31T03:49:34Z

PR_Github #13597 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10196 completed with status: 'FAILURE'

hyukn · 2025-07-31T04:48:56Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-31T04:54:28Z

PR_Github #13612 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-31T08:53:41Z

PR_Github #13612 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10209 completed with status: 'FAILURE'

Signed-off-by: Yukun He <[email protected]>

hyukn · 2025-07-31T13:35:11Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-07-31T13:40:26Z

PR_Github #13681 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-31T20:23:35Z

PR_Github #13681 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10273 completed with status: 'FAILURE'

hyukn · 2025-08-01T01:21:11Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-08-01T01:26:15Z

PR_Github #13739 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-01T02:46:46Z

PR_Github #13739 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10326 completed with status: 'SUCCESS'

…s. (NVIDIA#6417) Signed-off-by: Yukun He <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>

…s. (NVIDIA#6417) Signed-off-by: Yukun He <[email protected]>

coderabbitai bot requested review from litaotju and nv-yilinf July 28, 2025 15:46

hyukn force-pushed the fix/5419069 branch from 6bd4180 to b7f5d42 Compare July 30, 2025 13:20

coderabbitai bot requested review from crazydemo and yiqingy0 July 30, 2025 13:21

hyukn changed the title ~~[5419068] fix: Fix the mismatched layer name components.~~ [5419069] fix: Fix the mismatched layer name components. Jul 31, 2025

hyukn force-pushed the fix/5419069 branch from b7f5d42 to a84cac7 Compare July 31, 2025 04:48

coderabbitai bot requested a review from venkywonka July 31, 2025 04:48

[5419068] fix: Fix the mismatched layer name components.

addc4a5

Signed-off-by: Yukun He <[email protected]>

hyukn force-pushed the fix/5419069 branch from a84cac7 to addc4a5 Compare July 31, 2025 13:34

hyukn changed the title ~~[5419069] fix: Fix the mismatched layer name components.~~ [5419069][fix] Fix the mismatched layer name components. Aug 1, 2025

hyukn changed the title ~~[5419069][fix] Fix the mismatched layer name components.~~ [https://nvbugs/5419069][fix] Fix the mismatched layer name components. Aug 1, 2025

hyukn requested a review from QiJune August 1, 2025 08:07

QiJune approved these changes Aug 1, 2025

View reviewed changes

hyukn merged commit 90856bf into NVIDIA:main Aug 1, 2025
4 of 5 checks passed

lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025

[https://nvbugs/5419069][fix] Fix the mismatched layer name component…

a47c477

…s. (NVIDIA#6417) Signed-off-by: Yukun He <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>

jain-ria pushed a commit to jain-ria/TensorRT-LLM that referenced this pull request Aug 7, 2025

[https://nvbugs/5419069][fix] Fix the mismatched layer name component…

75b4fe2

…s. (NVIDIA#6417) Signed-off-by: Yukun He <[email protected]>

hyukn deleted the fix/5419069 branch October 31, 2025 09:18

[https://nvbugs/5419069][fix] Fix the mismatched layer name components. #6417

[https://nvbugs/5419069][fix] Fix the mismatched layer name components. #6417

Uh oh!

Conversation

hyukn commented Jul 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

hyukn commented Jul 28, 2025

Uh oh!

tensorrt-cicd commented Jul 28, 2025

Uh oh!

tensorrt-cicd commented Jul 28, 2025

Uh oh!

hyukn commented Jul 28, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

hyukn commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

hyukn commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

hyukn commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 30, 2025

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

hyukn commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

hyukn commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

hyukn commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

hyukn commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

hyukn commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

hyukn commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 28, 2025 •

edited

Loading